Skip to content

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented Jul 18, 2025

This adds coremltools support for transpose_copy, the copy variant of transpose. Many view ops in coremltools already register the copy variant as an alias, e.g.,

But it looks like for transpose this was missed.

@metascroy metascroy force-pushed the add-transpose-copy branch from a0f8537 to d474a96 Compare July 18, 2025 17:56
@bzcheeseman
Copy link
Collaborator

Hi @metascroy - thank you for your contribution! Would you mind adding a little more detail into your commit message/PR description? I'd love to get the reasoning behind the change recorded in the commit message.

@metascroy
Copy link
Contributor Author

Hi @metascroy - thank you for your contribution! Would you mind adding a little more detail into your commit message/PR description? I'd love to get the reasoning behind the change recorded in the commit message.

Added more detail

@YifanShenSZ
Copy link
Collaborator

LGTM! Thanks Scott for adding transpose_copy support 🙏

We might need to block merge until our release is done, @TobyRoseman to confirm

@metascroy
Copy link
Contributor Author

LGTM! Thanks Scott for adding transpose_copy support 🙏

We might need to block merge until our release is done, @TobyRoseman to confirm

Thanks @YifanShenSZ! Can you also have a look at the ExecuTorch PR when you get a chance: pytorch/executorch#12648

@metascroy metascroy mentioned this pull request Jul 18, 2025
@bzcheeseman
Copy link
Collaborator

CI passed, once @TobyRoseman has finished the release we can land this.

@TobyRoseman
Copy link
Collaborator

Thanks @metascroy for the pull request. We just did a big release. Please rebase this change on top of tip of main. Then I will kick off a CI run.

@metascroy metascroy mentioned this pull request Jul 28, 2025
@metascroy metascroy force-pushed the add-transpose-copy branch from d474a96 to 7d38c01 Compare July 29, 2025 23:43
@metascroy
Copy link
Contributor Author

Thanks @metascroy for the pull request. We just did a big release. Please rebase this change on top of tip of main. Then I will kick off a CI run.

Done

@TobyRoseman
Copy link
Collaborator

@YifanShenSZ YifanShenSZ merged commit 92aa7db into apple:main Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants