Skip to content

Conversation

ntBre
Copy link
Contributor

@ntBre ntBre commented Jul 29, 2025

Summary

This partially reverts commit 13634ff after issues in the release today.

Test Plan

uv build --sdist
tar -tzf dist/ruff-0.12.6.tar.gz | grep ruff-0.12.6/LICENSE

which finds the license now.

Summary
--

This partially reverts commit 13634ff after
issues in the release today.

Test Plan
--

```shell
uv build --sdist
tar -tzf dist/ruff-0.12.6.tar.gz | grep ruff-0.12.6/LICENSE
```

which finds the license now.
@ntBre ntBre merged commit 04a8f64 into main Jul 29, 2025
53 checks passed
@ntBre ntBre deleted the brent/revert-license-changes branch July 29, 2025 21:27
@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Jul 31, 2025

I have read #19599 and this PR, and don't understand the texst plan. Is the issue that uv build does not support PEP 639 yet and pushes license-less packages to PiPY?

@ntBre
Copy link
Contributor Author

ntBre commented Jul 31, 2025

I saw you got an answer on #19599, but you're right. I forgot all of the conversation around this was on Discord and could have included more context here. It might be helpful in the future.

During the 0.12.6 release, the sdist upload was rejected from PyPI for not containing the LICENSE file. I was able to verify that locally with the commands in the test plan. After the changes in this PR, the same commands confirmed that the LICENSE was back in the sdist before we tried another release.

As mentioned on #19599, the root cause seems to be a maturin bug, so we should be able to revert this revert at some point in the future.

@DimitriPapadopoulos
Copy link
Contributor

DimitriPapadopoulos commented Jul 31, 2025

Thank you so much. I have created draft PR #19661 that attempts to explain all known issues.

@DimitriPapadopoulos
Copy link
Contributor

Putting aside the main issue (the maturin bug):

It turns out pip-licences is not much maintained and has been forked into pip-licenses-cli which does support PEP 639. Also pip show has been updated and does support PEP 639 according to What's new in pip 25.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants