chore: make cleanup a bit safer #3346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have observed a lot of occasions where tests are being disturbed because resources are being deleted out from under them; either buckets or roles are being deletd while they are still being deployed. - List all resources in CloudFormation, and avoid hard-deleting any resource that is still managed by a CloudFormation stack. - In this PR, extend the notion of "staleness" (older than X hours) to stacks and apps, so we don't delete stacks and apps that might potentially still have tests running on them. - Increase the staleness period a little, because I've seen cleanup be too eager. - Put some time-traceability into the cleanup session's name, so we can start debugging a little easier than with just a random number.
mrgrain
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed a lot of occasions where tests are being disturbed because resources are being deleted out from under them; either buckets or roles are being deletd while they are still being deployed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.