Skip to content

Conversation

brandonskiser
Copy link
Contributor

@brandonskiser brandonskiser commented Sep 8, 2025

Description of changes:

  • Updating the execute_bash dangerous patterns list to include any references to $. Added a test as to why this is required.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@brandonskiser
Copy link
Contributor Author

cargo-deny is failing because bm25 depends on fxhash, which is apparently unmaintained - https://rustsec.org/advisories/RUSTSEC-2025-0057

Raised an issue to see if a fix can be applied in bm25 - Michael-JB/bm25#25

@brandonskiser brandonskiser marked this pull request as ready for review September 11, 2025 18:11
@brandonskiser brandonskiser merged commit d9c34dc into main Sep 11, 2025
14 of 15 checks passed
@brandonskiser brandonskiser deleted the bskiser/add-dangerous-pattern branch September 11, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants