Skip to content

fix: update dangerous patterns for execute bash to include $ #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

fix: update dangerous patterns for execute bash to include $ #2811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/chat-cli/src/cli/chat/tools/execute/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl ExecuteCommand {
let Some(args) = shlex::split(&self.command) else {
return true;
};
const DANGEROUS_PATTERNS: &[&str] = &["<(", "$(", "`", ">", "&&", "||", "&", ";", "${", "\n", "\r", "IFS"];
const DANGEROUS_PATTERNS: &[&str] = &["<(", "$(", "`", ">", "&&", "||", "&", ";", "$", "\n", "\r", "IFS"];

if args
.iter()
Expand Down Expand Up @@ -328,6 +328,7 @@ mod tests {
(r#"find / -fprintf "/path/to/file" <data-to-write> -quit"#, true),
(r"find . -${t}exec touch asdf \{\} +", true),
(r"find . -${t:=exec} touch asdf2 \{\} +", true),
(r#"find /tmp -name "*" -exe$9c touch /tmp/find_result {} +"#, true),
// `grep` command arguments
("echo 'test data' | grep -P '(?{system(\"date\")})'", true),
("echo 'test data' | grep --perl-regexp '(?{system(\"date\")})'", true),
Expand Down
Loading