feat(github-pull-requests-board): add composable home page component for pull request board #3997
Conversation
Signed-off-by: Jarred Channer <[email protected]> Signed-off-by: sageaaron <[email protected]> Co-Authored-By: sageaaron <[email protected]>
Signed-off-by: Jarred Channer <[email protected]>
Changed Packages
|
Signed-off-by: Jarred Channer <[email protected]>
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
Reopening this PR as discussed in the SIG today. |
| "@backstage/plugin-home": "^0.8.7", | ||
| "@backstage/plugin-home-react": "^0.1.25", |
There was a problem hiding this comment.
🤔 Should we generate a different package for this component? something like home-module-github-pull-request-board
maybe the home is quite common, but not sure if is better to not add possible unneeded dependencies
There was a problem hiding this comment.
I'm not sure what you try to ask here @Sarabadu? They need to import this package as it's being used in code, in the plugin.ts file.
| '@backstage-community/plugin-github-pull-requests-board': minor | ||
| --- | ||
|
|
||
| Adds a composable home page component to view pull requests for a team's repositories |
There was a problem hiding this comment.
it would de nice to include some lines on the readme on "how to use this home page component"
There was a problem hiding this comment.
Agree with this, can you please add some details about this new component to the README - https://github.com/backstage/community-plugins/blob/main/workspaces/github-pull-requests-board/plugins/github-pull-requests-board/README.md
| ); | ||
|
|
||
| /** @public */ | ||
| export const HomePageTeamPullRequestsCard = homePlugin.provide( |
There was a problem hiding this comment.
| export const HomePageTeamPullRequestsCard = homePlugin.provide( | |
| export const HomePageTeamPullRequestsCard = githubPullRequestsBoardPlugin.provide( |
You don't set this on the homePlugin but for the current plugin. Then you can remove line 23 above and the reference to this package in the package.json
| } from '@backstage/core-plugin-api'; | ||
| import { rootRouteRef } from './routes'; | ||
| import { createCardExtension } from '@backstage/plugin-home-react'; | ||
| import { homePlugin } from '@backstage/plugin-home'; |
| "@backstage/plugin-home": "^0.8.7", | ||
| "@backstage/plugin-home-react": "^0.1.25", |
There was a problem hiding this comment.
I'm not sure what you try to ask here @Sarabadu? They need to import this package as it's being used in code, in the plugin.ts file.
| "@backstage/frontend-plugin-api": "^0.10.0", | ||
| "@backstage/integration": "^1.16.2", | ||
| "@backstage/plugin-catalog-react": "^1.16.0", | ||
| "@backstage/plugin-home": "^0.8.7", |
There was a problem hiding this comment.
We can remove this line as we don't use anything from this package, there's a comment about this in the plugin.ts for full context,
| '@backstage-community/plugin-github-pull-requests-board': minor | ||
| --- | ||
|
|
||
| Adds a composable home page component to view pull requests for a team's repositories |
There was a problem hiding this comment.
Agree with this, can you please add some details about this new component to the README - https://github.com/backstage/community-plugins/blob/main/workspaces/github-pull-requests-board/plugins/github-pull-requests-board/README.md
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
4 participants
Hey, I just made a Pull Request!
Add a composable home page component that can display open pull requests for a team on the home page of a backstage instance. #3995
✔️ Checklist
Signed-off-byline in the message. (more info)