Skip to content

Conversation

Sarabadu
Copy link
Contributor

@Sarabadu Sarabadu commented Jul 23, 2025

Hey, I just made a Pull Request!

Why

We would like to use the Pull request board inside of the Manage plugin page and there is some in progress work to show the PR data inside the home page too. but ro now the plugin requires to be inside the EntityProvider context scope.

What

On this PR we are decoupling the EntityProvider from the rest of the board query and views.

Changes:

  • Removing the useEntity from the useUserRepositoriesAndTeam hook, and accepting one or more Entities
  • Create new component that accepts Entities and shows the Pull Request board for all the passed groups
  • Add the dev folder to have some better way to test it locally
  • Move refactor and add some tests

The existen componentes should not get affected by this change but we are exporting a new React component to be posible to use in other places

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-github-pull-requests-board workspaces/github-pull-requests-board/plugins/github-pull-requests-board patch v0.8.0

@Sarabadu Sarabadu force-pushed the gh-pr-board-reusable branch 2 times, most recently from 71d600f to c82e584 Compare July 23, 2025 12:32
@Sarabadu Sarabadu closed this Jul 23, 2025
@Sarabadu Sarabadu force-pushed the gh-pr-board-reusable branch from c82e584 to 7040e10 Compare July 23, 2025 12:34
@Sarabadu Sarabadu reopened this Jul 23, 2025
@Sarabadu Sarabadu force-pushed the gh-pr-board-reusable branch 6 times, most recently from 494d047 to 56dfdd8 Compare July 23, 2025 14:32
@Sarabadu Sarabadu force-pushed the gh-pr-board-reusable branch from 56dfdd8 to 52c0aa0 Compare July 23, 2025 14:39
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Copy link
Contributor

github-actions bot commented Aug 7, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 7, 2025
@Sarabadu
Copy link
Contributor Author

Sarabadu commented Aug 7, 2025

Not stale

@github-actions github-actions bot removed the stale label Aug 7, 2025
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Sarabadu, left one comment but overall looks good to me 👍

Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>

Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
@Sarabadu Sarabadu requested a review from awanlin August 11, 2025 12:37
repositories: teamData.repositories,
teamMembers: teamData.teamMembers,
teamMembersOrganization: getGithubOrganizationFromEntity(teamEntity),
teamMembersOrganization: getGithubOrganizationFromEntity(ownerEntities[0]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this plugin, does this mean it is always derived from the first entity? Perhaps that is intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, yes is intended, that field is used on the current EntityPage, that has always only 1 entity.

in the future if multiple organization tracking is needed i think it would be better to make a bigger refactor to decouple it a bit more, but as it now I tried to no go full down in the rabbit hole

Copy link
Collaborator

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming review comments considered. Dropping an a approving so this isn’t blocked while I’m OOO.

@Sarabadu
Copy link
Contributor Author

@awanlin, if you have some time, we still need your approval after the change request

Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let get this out :shipit:

@awanlin awanlin merged commit c2b33a1 into backstage:main Aug 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants