Fix timer map for TMOTORH743 #932
Conversation
WalkthroughTIMER_PIN_MAPPING in configs/TMOTORH743/config.h was reduced and reordered to nine active entries (indices 0–8). TIMUPx DMA option macros were updated: TIMUP2_DMA_OPT=10, TIMUP3_DMA_OPT=11, TIMUP8_DMA_OPT=12. Commented placeholders added for higher indices. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (6)📓 Common learnings📚 Learning: 2025-06-02T16:16:20.197ZApplied to files:
📚 Learning: 2025-08-28T20:45:36.652ZApplied to files:
📚 Learning: 2025-05-31T17:01:39.423ZApplied to files:
📚 Learning: 2025-07-14T15:41:14.364ZApplied to files:
📚 Learning: 2025-08-28T20:45:36.652ZApplied to files:
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
configs/TMOTORH743/config.h (1)
116-118: Clarify or remove commented-out timer mappings.These pins are designated for SPI6 (PB3=SCK, PB4=SDI, PB5=SDO) and should not have timer functionality. Consider either:
- Removing these lines entirely if they serve no purpose
- Adding a comment explaining why they're preserved (e.g., "Reserved for SPI6, do not enable timer functionality")
Apply this diff to remove the unnecessary commented lines:
#define TIMER_PIN_MAPPING TIMER_PIN_MAP( 0, PA0, 1, 0 ) \ TIMER_PIN_MAP( 1, PA1, 1, 1 ) \ TIMER_PIN_MAP( 2, PA2, 1, 2 ) \ TIMER_PIN_MAP( 3, PA3, 1, 3 ) \ TIMER_PIN_MAP( 4, PB0, 2, 4 ) \ TIMER_PIN_MAP( 5, PB1, 2, 5 ) \ TIMER_PIN_MAP( 6, PC8, 2, 6 ) \ TIMER_PIN_MAP( 7, PC9, 2, 7 ) \ TIMER_PIN_MAP( 8, PA8, 1, 14 ) - -// TIMER_PIN_MAP( 9, PB3, 1, 0 ) \ -// TIMER_PIN_MAP(10, PB4, 1, 0 ) \ -// TIMER_PIN_MAP(11, PB5, 1, 0 )
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
configs/TMOTORH743/config.h(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: haslinghuis
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-06-02T16:16:20.197Z
Learning: In STM32F405-based flight controller configurations, timer pin mappings must be carefully analyzed for DMA stream conflicts, especially between motor timers, LED strip timers, and SPI DMA assignments. Changes to TIMER_PIN_MAPPING should include verification that all required peripherals (motors, LED strip, blackbox SPI) can coexist without DMA conflicts.
Learnt from: haslinghuis
PR: betaflight/config#798
File: configs/FURYF4OSD/config.h:88-88
Timestamp: 2025-05-31T17:01:39.423Z
Learning: For STM32F4xx platforms, PB1 pin timer definitions are:
1 = DEF_TIM(TIM1, CH3N, PB1, 0, 0)
2 = DEF_TIM(TIM3, CH4, PB1, 0, 0)
3 = DEF_TIM(TIM8, CH3N, PB1, 0, 0)
Timer instance 2 (TIM3, CH4) is the correct mapping for PB1 motor control on STM32F4xx platforms as defined in src/platform/STM32/timer_stm32f4xx.c
Learnt from: haslinghuis
PR: betaflight/config#888
File: configs/ZEX_ATHENA_MINI/config.h:0-0
Timestamp: 2025-08-28T20:45:36.652Z
Learning: In STM32H743 Betaflight configurations, PA15 maps to TIM2_CH1 (timer index 2) as defined in timer_stm32h7xx.c. When used for GYRO_CLKIN functionality, it's recommended to use the macro name GYRO_1_CLKIN_PIN in TIMER_PIN_MAPPING for consistency with other pin definitions.
Learnt from: ot0tot
PR: betaflight/config#834
File: configs/RADIOLINKF405/config.h:79-88
Timestamp: 2025-07-14T15:41:14.364Z
Learning: In STM32F405 configurations, PB1 typically maps to TIM3_CH4 and PC9 typically maps to TIM8_CH4. These are different timers and do not share DMA resources, so there is no conflict when both pins are used simultaneously (e.g., PB1 for LED_STRIP and PC9 for MOTOR4).
Learnt from: haslinghuis
PR: betaflight/config#888
File: configs/ZEX_ATHENA_MINI/config.h:0-0
Timestamp: 2025-08-28T20:45:36.652Z
Learning: In STM32H743 Betaflight configurations, PB0 can use multiple timer options including TIM1_CH2N, TIM3_CH3, and TIM8_CH2N as defined in timer_stm32h7xx.c. For CAMERA_CONTROL_PIN assignments, TIM3_CH3 (timer index 3) is the appropriate choice.
📚 Learning: 2025-06-02T16:16:20.197Z
Learnt from: haslinghuis
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-06-02T16:16:20.197Z
Learning: In STM32F405-based flight controller configurations, timer pin mappings must be carefully analyzed for DMA stream conflicts, especially between motor timers, LED strip timers, and SPI DMA assignments. Changes to TIMER_PIN_MAPPING should include verification that all required peripherals (motors, LED strip, blackbox SPI) can coexist without DMA conflicts.
Applied to files:
configs/TMOTORH743/config.h
📚 Learning: 2025-08-28T20:45:36.652Z
Learnt from: haslinghuis
PR: betaflight/config#888
File: configs/ZEX_ATHENA_MINI/config.h:0-0
Timestamp: 2025-08-28T20:45:36.652Z
Learning: In STM32H743 Betaflight configurations, PA15 maps to TIM2_CH1 (timer index 2) as defined in timer_stm32h7xx.c. When used for GYRO_CLKIN functionality, it's recommended to use the macro name GYRO_1_CLKIN_PIN in TIMER_PIN_MAPPING for consistency with other pin definitions.
Applied to files:
configs/TMOTORH743/config.h
📚 Learning: 2025-05-31T17:01:39.423Z
Learnt from: haslinghuis
PR: betaflight/config#798
File: configs/FURYF4OSD/config.h:88-88
Timestamp: 2025-05-31T17:01:39.423Z
Learning: For STM32F4xx platforms, PB1 pin timer definitions are:
1 = DEF_TIM(TIM1, CH3N, PB1, 0, 0)
2 = DEF_TIM(TIM3, CH4, PB1, 0, 0)
3 = DEF_TIM(TIM8, CH3N, PB1, 0, 0)
Timer instance 2 (TIM3, CH4) is the correct mapping for PB1 motor control on STM32F4xx platforms as defined in src/platform/STM32/timer_stm32f4xx.c
Applied to files:
configs/TMOTORH743/config.h
📚 Learning: 2025-07-14T15:41:14.364Z
Learnt from: ot0tot
PR: betaflight/config#834
File: configs/RADIOLINKF405/config.h:79-88
Timestamp: 2025-07-14T15:41:14.364Z
Learning: In STM32F405 configurations, PB1 typically maps to TIM3_CH4 and PC9 typically maps to TIM8_CH4. These are different timers and do not share DMA resources, so there is no conflict when both pins are used simultaneously (e.g., PB1 for LED_STRIP and PC9 for MOTOR4).
Applied to files:
configs/TMOTORH743/config.h
📚 Learning: 2025-08-28T20:45:36.652Z
Learnt from: haslinghuis
PR: betaflight/config#888
File: configs/ZEX_ATHENA_MINI/config.h:0-0
Timestamp: 2025-08-28T20:45:36.652Z
Learning: In STM32H743 Betaflight configurations, PB0 can use multiple timer options including TIM1_CH2N, TIM3_CH3, and TIM8_CH2N as defined in timer_stm32h7xx.c. For CAMERA_CONTROL_PIN assignments, TIM3_CH3 (timer index 3) is the appropriate choice.
Applied to files:
configs/TMOTORH743/config.h
🔇 Additional comments (1)
configs/TMOTORH743/config.h (1)
106-114: Correctly fixes magnetometer detection by removing I2C pins from timer mapping.This change directly resolves issue #14724 by eliminating the resource conflict between timer and I2C peripherals. PB6 and PB7 are configured as I2C1_SCL and I2C1_SDA pins, and I2C1 is used for the magnetometer (MAG_I2C_INSTANCE). Having these pins in the timer mapping prevented proper I2C initialization, causing the "Not detected or disabled" error.
The new mapping correctly includes all required timer outputs:
- 8 motor outputs (PA0-PA3, PB0-PB1, PC8-PC9)
- 1 LED strip output (PA8)
Additionally, removing SPI6 pins (PB3-PB5) prevents similar peripheral conflicts.
|
@ot0tot feel free to make other changes |
Summary by CodeRabbit