vtprotocodec: user codecV2 for grpc client/server #8316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/grpc-use-codecv2
branch
from
33a1648 to
7824eb9
Compare
sluongng
changed the title
tylerwilliams
approved these changes
Feb 5, 2025
Member
tylerwilliams
left a comment
tylerwilliams
left a comment
There was a problem hiding this comment.
This LGTM but we should have @luluz66 take a look before submitting.
Should we switch server/util/proto.{Marshal,Unmarshal}() to V2 also (in another cl) ?
sluongng
force-pushed
the
sluongng/grpc-use-codecv2
branch
from
7824eb9 to
8216231
Compare
luluz66
reviewed
Feb 6, 2025
Switch to use codecV2 backed by the default buffer pool to handle all
Marshaling/Unmarshaling by grpc clients/servers. The default buffer pool
is already setup here.
```
server/util/grpc_client/grpc_client.go
254: experimental.WithBufferPool(mem.DefaultBufferPool()),
server/util/grpc_server/grpc_server.go
240: experimental.BufferPool(mem.DefaultBufferPool()),
```
This does not affect the manual Marshaling/Unmarshaling that we does via
`server/util/proto.{Marshal,Unmarshal}()`. These should still use V1 for
the time being.
sluongng
force-pushed
the
sluongng/grpc-use-codecv2
branch
from
8216231 to
3ed10ac
Compare
sluongng
force-pushed
the
sluongng/grpc-use-codecv2
branch
from
3ed10ac to
4341d9b
Compare
luluz66
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to use codecV2 backed by the default buffer pool to handle all
Marshaling/Unmarshaling by grpc clients/servers. The default buffer pool
is already setup here.
This does not affect the manual Marshaling/Unmarshaling that we does via
server/util/proto.{Marshal,Unmarshal}(). These should still use V1 forthe time being.
References: