Skip to content

feat: integrate jupyter-ui with ambient mesh #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Dec 3, 2025
Merged

feat: integrate jupyter-ui with ambient mesh #512

merged 26 commits into from
Dec 3, 2025
+4,026 −1,303

Conversation

@NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Nov 18, 2025 •
edited
Loading

Closes #510

Terraform checks failure is fixed by #513

Testing

  1. Deploy service mesh charms and add relations
juju add-model istio-system
juju deploy istio-k8s --trust --channel 2/edge

juju switch kubeflow
juju deploy istio-beacon-k8s --trust --channel 2/edge
juju config istio-beacon-k8s model-on-mesh=true
juju deploy istio-ingress-k8s --trust --channel 2/edge

# istio relations
juju offer istio-ingress-k8s:istio-ingress-config
juju switch istio-system
juju consume admin/kubeflow.istio-ingress-k8s
juju relate istio-k8s istio-ingress-k8s
juju switch kubeflow
  1. Deploy jupyter-ui charm from this PR
juju deploy jupyter-ui --channel=latest/edge/pr-512 --base [email protected] --trust
  1. Relate jupyter-ui charm to istio charms
juju relate istio-beacon-k8s:service-mesh jupyter-ui:service-mesh
juju relate istio-ingress-k8s:istio-ingress-route jupyter-ui:istio-ingress-route
  1. Check that charm went to active status
  2. Curl the gateway external IP with the /jupyter path:
curl 10.64.140.43/jupyter/

Expected output:

{"log":"No user detected.","status":401,"success":false,"user":null}

@NohaIhab NohaIhab marked this pull request as draft November 18, 2025 13:34
@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Nov 18, 2025
@NohaIhab NohaIhab marked this pull request as ready for review November 20, 2025 13:15
@NohaIhab NohaIhab requested a review from kimwnasptd November 20, 2025 13:58
kimwnasptd
kimwnasptd reviewed Nov 20, 2025
View reviewed changes
kimwnasptd
kimwnasptd reviewed Nov 20, 2025
View reviewed changes
@NohaIhab NohaIhab requested a review from kimwnasptd November 25, 2025 08:19
@NohaIhab NohaIhab mentioned this pull request Nov 27, 2025
Closed
@NohaIhab NohaIhab requested a review from MattiaSarti December 2, 2025 13:29
kimwnasptd
kimwnasptd approved these changes Dec 2, 2025
View reviewed changes
Copy link
Collaborator

@kimwnasptd kimwnasptd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look super clean!

MattiaSarti
MattiaSarti requested changes Dec 2, 2025
View reviewed changes
@NohaIhab NohaIhab requested a review from MattiaSarti December 3, 2025 10:28
MattiaSarti
MattiaSarti approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@MattiaSarti MattiaSarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@NohaIhab NohaIhab merged commit d6d67bd into main Dec 3, 2025
22 checks passed
@NohaIhab NohaIhab deleted the kf-8146-integrate-with-ambient-mesh branch December 3, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimwnasptd kimwnasptd kimwnasptd approved these changes

@MattiaSarti MattiaSarti MattiaSarti approved these changes

Assignees

No one assigned

Labels

Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate jupyter-ui with ambient mesh charms

4 participants

@NohaIhab @kimwnasptd @MattiaSarti