Skip to content

feat: integrate jupyter-ui with ambient mesh #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 3, 2025
Merged

feat: integrate jupyter-ui with ambient mesh #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3bf57c5
feat: add service mesh libs and deps
NohaIhab Nov 18, 2025
eca8676
feat: add relations and implement requirer side
NohaIhab Nov 18, 2025
3ee5a9c
fix: submit ingress config if leader
NohaIhab Nov 18, 2025
1061fda
update unit tests
NohaIhab Nov 18, 2025
f1dbe4f
fix: lint
NohaIhab Nov 18, 2025
5212141
remove empty policies arg and update docstring
NohaIhab Nov 19, 2025
455224a
Merge branch 'main' into kf-8146-integrate-with-ambient-mesh
NohaIhab Nov 20, 2025
e0fd6a3
skip: address comments
NohaIhab Nov 25, 2025
fdf07c3
upate istio_ingress_route lib and define filter
NohaIhab Nov 25, 2025
5f60ed4
feat: add ambient integration tests
NohaIhab Nov 25, 2025
3762c61
handle both relations and update tests
NohaIhab Nov 26, 2025
fda5599
update tox and ci to run ambient tests
NohaIhab Nov 26, 2025
6c35ff6
skip: lint
NohaIhab Nov 26, 2025
9a06008
feat: use chisme utilities in tests from https://github.com/canonical…
NohaIhab Nov 28, 2025
78b30df
skip: lint
NohaIhab Nov 28, 2025
96e223d
tests: update chisme to 0.4.15
NohaIhab Dec 2, 2025
22f8141
skip: update tox.ini
NohaIhab Dec 2, 2025
57b5622
skip: correct tox env name
NohaIhab Dec 2, 2025
f8ccc40
skip: use get_http_response from chisme
NohaIhab Dec 2, 2025
1a5b164
review: use constants for relation names
NohaIhab Dec 3, 2025
aeb4242
review: remove unused charms_dependencies.py
NohaIhab Dec 3, 2025
0bf15e8
review: update tests
NohaIhab Dec 3, 2025
50c3d40
review: revert changes to charmcraft.yaml
NohaIhab Dec 3, 2025
d36ff8a
review: remove lightkube from test deps
NohaIhab Dec 3, 2025
1f959be
review: add comment to tox.ini on missing env
NohaIhab Dec 3, 2025
f0fa192
review: rename expected config variable
NohaIhab Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ jobs:
charm:
- jupyter-controller
- jupyter-ui
test-type: [integration, integration-ambient]
# TODO: Remove this exclusion once jupyter-controller integration-ambient tests are implemented
exclude:
- charm: jupyter-controller
test-type: integration-ambient
steps:
- uses: actions/checkout@v4
- name: Install dependencies
Expand All @@ -174,6 +179,4 @@ jobs:
# Pass the path where the charm artefact is downloaded to the tox command
# FIXME: Right now the complete path is half hardcoded to <charm name>[email protected]
# We need to find a better way to dynamically get this value
tox -e ${{ matrix.charm }}-integration -- --model kubeflow --charm-path=${{ github.workspace }}/charms/${{ matrix.charm }}/${{ matrix.charm }}[email protected]


tox -e ${{ matrix.charm }}-${{ matrix.test-type }} -- --model kubeflow --charm-path=${{ github.workspace }}/charms/${{ matrix.charm }}/${{ matrix.charm }}[email protected]
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ geckodriver.log
venv/
.terraform*
*.tfstate*
coverage.xml
Loading