-
Notifications
You must be signed in to change notification settings - Fork 154
build(performance): rolldown-vite integration
#7956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(performance): rolldown-vite integration
#7956
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…llo/ibm-products into 7953-rolldown-vite-integration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7956 +/- ##
==========================================
+ Coverage 79.38% 85.62% +6.24%
==========================================
Files 474 354 -120
Lines 20340 16868 -3472
Branches 5006 3986 -1020
==========================================
- Hits 16146 14444 -1702
+ Misses 4194 2424 -1770
🚀 New features to boost your workflow:
|
|
Hey 👋🏻 The perf improvements seem rather low, which is strange 🤔 You also want to make sure to enable native plugins for improved performance in the Vite configs. I suppose beyond the storybook time (where there is a lot of things to improve in storybook itself by replacing rollup or esbuild), replacing the existing build script with either tsdown or plain rolldown could be worth it too (but that is another PR of course) - and also get rid of the slow babel parts! |
|
Hey @TheAlexLichter, thanks for the insights, super helpful! I'll take a look at And yeah, I definitely agree that replacing the actual project build script is something we'll want to look at next. |
|
@matthewgallo In general, build perf should be way better - but given that there are a lot of optimizations that can be (and have to be) done on the Storybook side, the difference is rather small right now. We are looking into PRs and issues to improve the situation there. The builds script migration should speed up things way more for that part. |
|
Hey @matthewgallo, Can you resolve the merge conflict? |
|
This PR got quite stale, going to open a new one. |
Closes #7953
This PR introduces
rolldown-viteinto our storybook build configuration. The initial benchmark comparison between build times looks like a solid improvement:Performance comparison
Build times for
@carbon/ibm-productsrolldown-viterolldown-vitelocal machine~20% decrease in total build times (in CI environment)
What did you change?
*.jsfiles containing jsx syntax to*.jsx*.jsxfile extension to any import of a file that hasn't migrated to*.tsxyetRemoved unsupported css syntaxUpdated@property --some-property { initial-value: 1px },lightningcsswhich is used byrolldown-viteis not able to process this syntax@property { syntax }tolengthHow did you test and verify your work?
Ran storybook locally and successfully built
ibm-productslocallyPR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request section of
our contributing docs.