Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rgcase
left a comment
rgcase
left a comment
There was a problem hiding this comment.
Looks pretty good, thanks Joe. I left a few comments but nothing big.
|
|
||
| Provision a new Azure subscription with no existing infrastructure, dedicated to your CockroachDB {{ site.data.products.cloud }} deployment. This subscription can be reused for multiple CockroachDB clusters. | ||
|
|
||
| ## Step 2. Grant IAM permissions to Cockroach Labs |
There was a problem hiding this comment.
FYI this process is going to change some in the near future, but it might not be until after we've published these docs. Here are a couple Google docs describing the new process https://docs.google.com/document/d/1y9bxvTjMTPs7RuTw4APTSdTEGdMsWEju8hcuKIzz2h8 and https://docs.google.com/document/d/16MOr0f3f4-OOVSFVUd9d7fF2X09GLk831gjgs19PMOY.
There was a problem hiding this comment.
Created https://cockroachlabs.atlassian.net/browse/DOC-16141 to capture the follow-up task, if you can comment on that with any linked issues/PRs.
jhlodin
force-pushed
the
jl/doc-14974
branch
3 times, most recently
from
7e52bb2 to
4f04a85
Compare
rmloveland
left a comment
rmloveland
left a comment
There was a problem hiding this comment.
LGTM, just had some suggestions for moar links
| ] | ||
| }, | ||
| { | ||
| "title": "BYOC Deployments (Preview)", |
There was a problem hiding this comment.
non-blocking: i'm mildly anti putting "preview" in the TOC because it adds another touchpoint that could be forgotten when we remove from preview - however this is not in the style guide and just, like, my opinion
There was a problem hiding this comment.
I agree normally. But this is a weird situation where BYOC is something that's already been openly marketed and talked about without calling it out adequately as a preview. So I think it's necessary to make that crystal clear for now.
The ETA for GA is later this quarter anyway. It shouldn't be long and this nav will be changed to accommodate those changes so I'm confident we'll catch this.
|
@jhlodin ping on this PR. Can we merge it soon? |
jhlodin
force-pushed
the
jl/doc-14974
branch
from
1e74f4d to
bb33f83
Compare
3 participants
https://cockroachlabs.atlassian.net/browse/DOC-14974