Fixed Network Policy Template #297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `{{- with ... }}` seems useless here, and it breaks everything else. I think(?) it doesn't cause an issue in the default configuration because `.Values.networkPolicy.ingress.grpc` is an empty array (and I guess that means it doesn't actually switch into that scope?).
Would be nice™ to add a test too (I made this PR from the GitHub web app).
|
Any news on getting this into a release? This would benefit our team greatly |
|
I'd also like to see this reviewed and merged |
|
Can you remove the changes in the |
Spacebjorn
reviewed
Jul 17, 2023
| name: cockroachdb | ||
| home: https://www.cockroachlabs.com | ||
| version: 10.0.6 | ||
| version: 10.0.7 |
There was a problem hiding this comment.
Suggested change
| version: 10.0.7 | |
| version: 10.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Bugfix was originally created by @travigd and is discussed here: #25
I've only bumped the chart version so the fix should be mergable.