Do not display an error when an action didn't run

[sebjulliand]

Changes

This PR prevents the error notification from showing up when a Custom action has a prompt (either a custom prompt or a ? prompt) and that prompt is closed or cancelled.

How to test this PR

Run the test on a single item and on multiple items too

1. Run an action with a prompt
2. Close the prompt or click on Cancel
3. Nothing must show up or happen

Checklist

• have tested my change

[github-actions]

👋 A new build is available for this PR based on 82d6c1f.

• Download here.
• Read more about how to test

[chrjorgensen]

@sebjulliand Did some testing of this PR - and your change seems to work.

However, I got some errors during testing:

1. I ran an action with one command CRTCMD on a .cmd streamfile - no error, it compiled fine.
2. I duplicated the action above and added a CPY command in front, so it had CPY and CRTCMD, and ran this action. Now it failed with the following errors:

and the terminal showed this:

Fetching errors for CJORGENS1/'.
Error: Failed fetching table: CPD0012:  Characters in qualifier beginning 'VSCODETEMP' not valid.
             CPD0014:  A matching apostrophe not found.
                                                       CPD0013:  A matching parenthesis not found.
              CPF0001:  Error found on *N command.

This must an old error, because it also occurs running on code from the master branch.
Maybe the *EVENTF file retrieve code failing to generate the correct object name?

[chrjorgensen]

@sebjulliand

either a custom prompt or a ! prompt

What is a ! prompt? Do you mean the ? prompt?

[chrjorgensen]

@sebjulliand I think my comment above is an error in the old code - especially after working on PR #2926. You should probably just ignore that...

[sebjulliand]

You're right my friend. I meant to write ? prompt.

[sebjulliand]

@sebjulliand I think my comment above is an error in the old code - especially after working on PR #2926. You should probably just ignore that...

I'll check it out since I think I had the same error lately. Better fix it here while I'm at it. At least I'll fix the message that shows [Object object]

[sebjulliand]

Back at you @chrjorgensen !
I just did minor fixes. I guess the event file retrieval should be fool-proofed in #2926.

[chrjorgensen]

@sebjulliand Works as expected. 👍

Two remarks for some future PR's:

1. If running an action with prompted command on multiple targets, the command is only prompted once. I would have thought it would be prompted for each target. Isn't that more logical?
2. When the command is prompted, the variables are not replaced in the prompt, e.g. &NAME is still there instead of the name of the file.

These issues are in the master branch and need a new PR.

[sebjulliand]

@sebjulliand Works as expected. 👍

Many thanks @chrjorgensen for your review.

Two remarks for some future PR's:

1. If running an action with prompted command on multiple targets, the command is only prompted once. I would have thought it would be prompted for each target. Isn't that more logical?

No, this was done on purpose, to prompt once and run many times. It felt wrong to show the prompt for each target.

2. When the command is prompted, the variables are not replaced in the prompt, e.g. `&NAME` is still there instead of the name of the file.

Which is related to the point above. It should be replaced when running on a single target though.