Skip to content

Do not display an error when an action didn't run #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2025
Merged

Do not display an error when an action didn't run #2905

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
647c9b1
Do not display an error when an action didn't run
sebjulliand Oct 1, 2025
4e7e2a6
Fixed CSS indentation
sebjulliand Nov 5, 2025
82d6c1f
Fixed internal error message to show actual action name
sebjulliand Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 52 additions & 46 deletions src/ui/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ export async function runAction(instance: Instance, uris: vscode.Uri | vscode.Ur
//Prompt once now in case of multiple targets
const promptOnce = targets.length > 1;
const command = promptOnce ? await commandConfirm(chosenAction.command) : chosenAction.command;
if (!command) {
return false;
}

await vscode.window.withProgress({ location: vscode.ProgressLocation.Notification, cancellable: true, title: l10n.t("Running action {0} on", chosenAction.name, targets.length) }, async (task, canceled) => {
const increment = 100 / targets.length;
Expand Down Expand Up @@ -502,7 +505,7 @@ export async function runAction(instance: Instance, uris: vscode.Uri | vscode.Ur

} catch (e) {
writeEmitter.fire(`${e}\n`);
vscode.window.showErrorMessage(`Action ${chosenAction} for ${evfeventInfo.library}/${evfeventInfo.object} failed. (internal error).`);
vscode.window.showErrorMessage(`Action ${chosenAction.name} for ${evfeventInfo.library}/${evfeventInfo.object} failed. (internal error).`);
successful = false;
}

Expand All @@ -524,53 +527,56 @@ export async function runAction(instance: Instance, uris: vscode.Uri | vscode.Ur
}
});

const openOutputAction = l10n.t("Open output(s)");
let uiPromise;
if (cancelled) {
uiPromise = vscode.window.showWarningMessage(l10n.t(`Action {0} was cancelled; ({1} processed).`, chosenAction.name, targets.filter(target => target.processed).length), openOutputAction);
}
else if (targets.every(target => target.executionOK)) {
uiPromise = vscode.window.showInformationMessage(l10n.t(`Action {0} was successful.`, chosenAction.name), openOutputAction);
}
else {
uiPromise = vscode.window.showErrorMessage(l10n.t(`Action {0} was not successful ({1}/{2} failed).`, chosenAction.name, targets.filter(target => !target.executionOK).length, targets.length), openOutputAction);
}
if (targets.some(target => target.hasRun)) {
const openOutputAction = l10n.t("Open output(s)");
let uiPromise;
if (cancelled) {
uiPromise = vscode.window.showWarningMessage(l10n.t(`Action {0} was cancelled; ({1} processed).`, chosenAction.name, targets.filter(target => target.processed).length), openOutputAction);
}
else if (targets.every(target => target.executionOK)) {
uiPromise = vscode.window.showInformationMessage(l10n.t(`Action {0} was successful.`, chosenAction.name), openOutputAction);
}
else {
uiPromise = vscode.window.showErrorMessage(l10n.t(`Action {0} was not successful ({1}/{2} failed).`, chosenAction.name, targets.filter(target => !target.executionOK).length, targets.length), openOutputAction);
}

uiPromise.then(openOutput => {
if (openOutput) {
const now = new Date();
const resultsPanel = new CustomUI();
if (targets.length === 1) {
resultsPanel.addParagraph(`<pre>${targets[0].output.join("")}</pre>`)
.setOptions({ fullPage: true ,
css: /* css */ `
pre{
background-color: transparent;
}
`
});
}
else {
resultsPanel.addBrowser("results", targets.filter(target => target.processed).map(target => ({ label: `${getTargetResultIcon(target)} ${path.basename(target.uri.path)}`, value: `<pre>${target.output.join("")}</pre>` } as TreeListItem)))
.setOptions({
fullPage: true,
css: /* css */ `
body{
margin: 0;
padding: 0;
overflow: hidden;
}

pre {
margin: 1em;
background-color: transparent;
}
`
});
uiPromise.then(openOutput => {
if (openOutput) {
const now = new Date();
const resultsPanel = new CustomUI();
if (targets.length === 1) {
resultsPanel.addParagraph(`<pre>${targets[0].output.join("")}</pre>`)
.setOptions({
fullPage: true,
css: /* css */ `
pre{
background-color: transparent;
}
`
});
}
else {
resultsPanel.addBrowser("results", targets.filter(target => target.processed).map(target => ({ label: `${getTargetResultIcon(target)} ${path.basename(target.uri.path)}`, value: `<pre>${target.output.join("")}</pre>` } as TreeListItem)))
.setOptions({
fullPage: true,
css: /* css */ `
body{
margin: 0;
padding: 0;
overflow: hidden;
}

pre {
margin: 1em;
background-color: transparent;
}
`
});
}
resultsPanel.loadPage(`${chosenAction.name} [${now.toLocaleString()}]`);
}
resultsPanel.loadPage(`${chosenAction.name} [${now.toLocaleString()}]`);
}
})
})
}
}
return targets.every(target => target.executionOK);
}
Expand Down
Loading