Skip to content

Conversation

yangm2
Copy link
Contributor

@yangm2 yangm2 commented Aug 15, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Always runs coverage with pytest and enforces minimum coverage level (currently set to 85% in pyproject.toml).

% make test
.
.
.
ERROR: Coverage failure: total of 81 is less than fail-under=85


============================================================================================================================== tests coverage ==============================================================================================================================
_____________________________________________________________________________________________________________ coverage: platform linux, python 3.12.3-final-0 ______________________________________________________________________________________________________________

Name                          Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------
tenantfirstaid/__init__.py        0      0      0      0   100%
tenantfirstaid/app.py            61      9     10      4    79%   11->16, 33, 49->59, 82-83, 88-89, 109-112, 123
tenantfirstaid/chat.py           48      0      4      0   100%
tenantfirstaid/citations.py      14      0      4      0   100%
tenantfirstaid/feedback.py       31     22      8      0    23%   12-16, 20-50
tenantfirstaid/session.py        55      0      4      0   100%
-------------------------------------------------------------------------
TOTAL                           209     31     30      4    81%
FAIL Required test coverage of 85.0% not reached. Total coverage: 81.17%
=========================================================================================================================== 14 passed in 20.70s ============================================================================================================================
make: *** [Makefile:38: test] Error 1

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Documentation

  • If this PR changes the system architecture, Architecture.md has been updated

[optional] Are there any post deployment tasks we need to perform?

@yangm2 yangm2 added enhancement New feature or request backend Bot implementation and other backend concerns Not ready labels Aug 15, 2025
@yangm2
Copy link
Contributor Author

yangm2 commented Aug 15, 2025

@claude push changes to this PR which tests tenantfirstaid/feedback.py

Copy link
Contributor

claude bot commented Aug 15, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

@yangm2
Copy link
Contributor Author

yangm2 commented Aug 18, 2025

The enforcement works (fails when coverage is too low) ... now need to add tests for feedback.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Bot implementation and other backend concerns enhancement New feature or request Not ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant