Skip to content

Minimum pytest coverage #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Minimum pytest coverage #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fb4843
run coverage and enforce minimum coverage in Makefile and GHA/PR-Check
yangm2 Aug 15, 2025
7fb9262
bump uv version in GHA
yangm2 Aug 15, 2025
6ce2e32
bump setuptools
yangm2 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
enable-cache: true
cache-dependency-glob: "backend/uv.lock"
# Install a specific version of uv.
version: "0.7.13"
version: "0.8.11"

- name: Set up Python
run: uv python install
Expand All @@ -43,7 +43,7 @@ jobs:
run: uv run ty check

- name: Run tests
run: uv run pytest -v -s
run: uv run pytest -v -s --cov

frontend-build:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion backend/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ typecheck-pyrefly: uv.lock
$(PYTHON) run pyrefly check $(TYPECHECK_OPTIONS) --python-interpreter .venv/bin/python3

test: uv.lock
uv run pytest -v -s $(TEST_OPTIONS)
uv run pytest -v -s $(TEST_OPTIONS) --cov

clean:
find . -type d -name '__pycache__' -exec rm -r {} +
Expand Down
10 changes: 9 additions & 1 deletion backend/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,17 @@ where = ["."]
exclude = ["data*"]

[build-system]
requires = ["setuptools>=61"]
requires = ["setuptools>=80"]
build-backend = "setuptools.build_meta"

[tool.coverage.run]
branch = true
source = ["tenantfirstaid"]

[tool.coverage.report]
fail_under = 85.0 # percentage of overall coverage
show_missing = true

[dependency-groups]
dev = [
"ipdb>=0.13.13",
Expand Down
Loading