Skip to content

Fix/bottom nav visibility mediadetails #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 5, 2025
Merged

Fix/bottom nav visibility mediadetails #6520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc7ce34
Ensure bottom navigation bar is visible on back navigation
Kota-Jagadeesh Oct 16, 2025
976e211
Prevent hiding bottom navigation bar in MediaDetailPagerFragment
Kota-Jagadeesh Oct 16, 2025
ce2f094
Merge branch 'main' into fix/bottom-nav-visibility-mediadetails
nicolas-raoul Nov 3, 2025
1eb44cd
Removed the redundant showTabs() calls from onBackPressed() as they …
Kota-Jagadeesh Nov 3, 2025
68163f6
Explicitly hide and show the bottom navigation bar on entering/exitin…
Kota-Jagadeesh Nov 3, 2025
a892212
Merge branch 'main' into fix/bottom-nav-visibility-mediadetails
nicolas-raoul Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ import fr.free.nrw.commons.category.CategoryClient
import fr.free.nrw.commons.category.CategoryDetailsActivity
import fr.free.nrw.commons.category.CategoryEditHelper
import fr.free.nrw.commons.contributions.ContributionsFragment
import fr.free.nrw.commons.contributions.MainActivity
import fr.free.nrw.commons.coordinates.CoordinateEditHelper
import fr.free.nrw.commons.databinding.FragmentMediaDetailBinding
import fr.free.nrw.commons.delete.DeleteHelper
Expand Down Expand Up @@ -793,6 +794,14 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C
super.onDestroyView()
}

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
if (activity is MainActivity) {
//explicitly hides the tabs when the media details screen is opened.
(activity as MainActivity).hideTabs()
}
}

private fun setTextFields(media: Media) {
setupImageView()
binding.mediaDetailTitle.text = media.displayTitle
Expand Down
10 changes: 8 additions & 2 deletions app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@ class MediaDetailPagerFragment : CommonsDaggerSupportFragment(), OnPageChangeLis
// If fragment is associated with ProfileActivity, then hide the tabLayout
if (activity is ProfileActivity) {
(activity as ProfileActivity).setTabLayoutVisibility(false)
} else if (activity is MainActivity) {
(activity as MainActivity).hideTabs()
}

binding!!.mediaDetailsPager.adapter = adapter
Expand Down Expand Up @@ -142,6 +140,14 @@ class MediaDetailPagerFragment : CommonsDaggerSupportFragment(), OnPageChangeLis
initProvider()
}

override fun onDestroyView() {
super.onDestroyView()
if (activity is MainActivity) {
(activity as MainActivity).showTabs()
}
binding = null
}

/**
* initialise the provider, based on from where the fragment was started, as in from an activity
* or a fragment
Expand Down