Skip to content

Conversation

@Kota-Jagadeesh
Copy link
Collaborator

Fix Bottom Navigation Bar Disappearing in MediaDetailPagerFragment

Changes

  • MediaDetailPagerFragment.kt: Removed the hideTabs() call in onCreateView to prevent hiding the bottom navigation bar when displaying media details, ensuring it remains visible as per the requirement.
  • MainActivity.kt: Added showTabs() calls in the onBackPressed method for all navigation cases to ensure the bottom navigation bar is restored when navigating back from any fragment, providing a robust fallback.

Testing

  • Navigated from Nearby to Explore > Map tab, clicked a picture to open the bottom sheet, and then clicked "Details" to view MediaDetailPagerFragment. Verified that the bottom navigation bar remains visible.
  • Tested back navigation to ensure the navigation bar stays visible when returning to the Explore tab.
  • Tested other navigation paths (e.g., Contributions and Bookmarks to media details) to confirm consistent visibility of the navigation bar.

Fixes #6316

@nicolas-raoul
Copy link
Member

This bug prevents me from testing: #6530

Are you getting the same bug?

Thanks!

@Kota-Jagadeesh
Copy link
Collaborator Author

This bug prevents me from testing: #6530

Are you getting the same bug?

Thanks!

@nicolas-raoul Yep, even i am getting the same bug (#6530)
I tried this with the main branch as well, but the result is same.

@Kota-Jagadeesh
Copy link
Collaborator Author

@nicolas-raoul This PR fixes the issue #6316 - Can we merge this PR ?

@nicolas-raoul
Copy link
Member

Sorry I have very limited time this week. 😱

@Kota-Jagadeesh
Copy link
Collaborator Author

Sorry I have very limited time this week. 😱

No worries! Thanks for the update - I’ll check back next week for your review.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that it is normal for the bottom navigation bar to not be visible in Media Details, but it must be visible in Contributions.

Unfortunately, in this branch the bottom navigation bar is visible in Media Details when going via Nearby>Explore>Details... would you mind making it not appear in Media Details?

Thanks! :-)

@Kota-Jagadeesh
Copy link
Collaborator Author

@nicolas-raoul Updated the branch with the required changes, Could you please review it and let me know if there are any changes required ?

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixes the issue, thanks!

@nicolas-raoul nicolas-raoul merged commit a2805a3 into commons-app:main Nov 5, 2025
1 check passed
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

✅ Generated APK variants!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom navigation bar disappears when tapping Nearby>Explore>Details

2 participants