-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix/bottom nav visibility mediadetails #6520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/bottom nav visibility mediadetails #6520
Conversation
|
This bug prevents me from testing: #6530 Are you getting the same bug? Thanks! |
@nicolas-raoul Yep, even i am getting the same bug (#6530) |
|
@nicolas-raoul This PR fixes the issue #6316 - Can we merge this PR ? |
|
Sorry I have very limited time this week. 😱 |
No worries! Thanks for the update - I’ll check back next week for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that it is normal for the bottom navigation bar to not be visible in Media Details, but it must be visible in Contributions.
Unfortunately, in this branch the bottom navigation bar is visible in Media Details when going via Nearby>Explore>Details... would you mind making it not appear in Media Details?
Thanks! :-)
…re no longer needed
|
@nicolas-raoul Updated the branch with the required changes, Could you please review it and let me know if there are any changes required ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That fixes the issue, thanks!
|
✅ Generated APK variants! |
Fix Bottom Navigation Bar Disappearing in MediaDetailPagerFragment
Changes
hideTabs()call inonCreateViewto prevent hiding the bottom navigation bar when displaying media details, ensuring it remains visible as per the requirement.showTabs()calls in theonBackPressedmethod for all navigation cases to ensure the bottom navigation bar is restored when navigating back from any fragment, providing a robust fallback.Testing
MediaDetailPagerFragment. Verified that the bottom navigation bar remains visible.Fixes #6316