Enable exceptions deployment #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbarton
force-pushed
the
enable-exceptions-deployment
branch
from
3bcb086 to
b2cd52a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 9 9
Lines 3921 3921
=======================================
Hits 3120 3120
Misses 801 801 🚀 New features to boost your workflow:
|
|
To enable exception handling in the deployment on main, the emscripten cache would need to be deleted before this PR gets merged in. |
4 tasks
mcbarton
force-pushed
the
enable-exceptions-deployment
branch
from
b2cd52a to
10a44de
Compare
4 tasks
|
@anutosh491 pinging for your review on this. Should be very quick to review, since you wrote the patch that this PR uses, and is already being made use of in Emscripten forge |
anutosh491
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
CppInterOps xeus-cpp deployment doesn't have exception handling working due to this patch being missing from the llvm build. This patch was taken from Emscripten forge here https://github.com/emscripten-forge/recipes/blob/main/recipes/recipes_emscripten/llvm/patches/enable_exception_handling.patch . I have tested this patch locally to check it fixes the deployment.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist