Skip to content

Update go version requirement to 1.21.x in docs #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

asmarton
Copy link

@asmarton asmarton commented May 6, 2024

No description provided.

@TomSweeneyRedHat
Copy link
Member

LGMT
and TYVM for the update @brown121407 !

@TomSweeneyRedHat
Copy link
Member

LGTM
(typing is not my specialty)

@TomSweeneyRedHat
Copy link
Member

@brown121407 sorry, I just noted that you didn't sign your commit. Could you git commit --amend -s and then repush please?

@rhatdan
Copy link
Member

rhatdan commented Aug 6, 2024

@brown121407 Are you still working on this one?

TomSweeneyRedHat added a commit to TomSweeneyRedHat/podman.io that referenced this pull request Aug 7, 2025
This will replace containers#303.  The changes were great, but our CI won't allow
for merges until a PR is signed and we unfortunately could not get
@asmarton to update their PR.

This adds those fixes.

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat
Copy link
Member

Closing. As this one was never signed, I've replicated the changes in #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants