Bump required go version in install.md #422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will replace containers#303. The changes were great, but our CI won't allow for merges until a PR is signed and we unfortunately could not get @asmarton to update their PR. This adds those fixes. Signed-off-by: tomsweeneyredhat <[email protected]>
lsm5
reviewed
Aug 12, 2025
| The current minimum required version can always be found in the [go.mod](https://github.com/containers/podman/blob/main/go.mod) file. | ||
| If needed, golang kits are available at https://golang.org/dl/. Alternatively, go can be built from source as follows | ||
| If needed, Golang kits are available at https://golang.org/dl/. Alternatively, go can be built from source as follows |
There was a problem hiding this comment.
Suggested change
| If needed, Golang kits are available at https://golang.org/dl/. Alternatively, go can be built from source as follows | |
| If needed, Go binary and source releases are available at https://golang.org/dl/. Alternatively, Go can be built from source as follows |
|
|
||
| Be careful to double-check that the version of golang is new enough (i.e. `go version`), as of January 2022 version is 1.16.x or higher is required. | ||
| Be careful to double-check that the version of Golang is new enough (i.e., `go version`). As of May 2024, version 1.21.x or higher is required. |
There was a problem hiding this comment.
Suggested change
| Be careful to double-check that the version of Golang is new enough (i.e., `go version`). As of May 2024, version 1.21.x or higher is required. | |
| Be careful to double-check that the version of Go is new enough (i.e., `go version`). As of May 2024, version 1.21.x or higher is required. |
| @@ -443,11 +443,11 @@ echo 'kernel.unprivileged_userns_clone=1' > /etc/sysctl.d/userns.conf | |||
| If any dependencies cannot be installed or are not sufficiently current, they have to be built from source. | |||
| This will mainly affect Debian, Ubuntu, and related distributions, or RHEL where no subscription is active (e.g. Cloud VMs). | |||
|
|
|||
| #### golang | |||
| #### Golang | |||
There was a problem hiding this comment.
Suggested change
| #### Golang | |
| #### Go |
| @@ -510,7 +510,7 @@ apt-get install -y \ | |||
|
|
|||
| ### Get Source Code | |||
|
|
|||
| First, ensure that the `go version` that is found first on the $PATH is 1.16.x or higher. Instruction [above](#golang) will help you compile newer version of Go if needed. Then we can build Podman: | |||
| First, ensure that the `go version` that is found first on the $PATH is 1.21.x or higher. Instruction [above](#golang) will help you compile newer version of Go if needed. Then we can build Podman: | |||
There was a problem hiding this comment.
I think (#golang) would also have to change here based on how you handle line 446.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace #303. The changes were great, but our CI won't allow for merges until a PR is signed and we unfortunately could not get @asmarton to update their PR.
This adds those fixes.