install: fix macos code signing #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
btw the "Open In..." feature works, even tho these games dropped Mac support |
Owner
VPKEdit doesn't use the Steam API to access these games, it just reads Steam's config files. So if a Source engine game is considered installed by Steam its assets will be accessible. Good to know that works though, I never tested that library on macOS |
craftablescience
requested changes
Oct 4, 2025
Owner
|
Oops didn't fully read the PR description |
craftablescience
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the app bundle properly ad-hoc signed so running
xattrto bring the application out of quarantine isn't necessary anymore, but the user still needs to go toSystem Settings->Privacy & Securityand scroll down toSecurityand allow the application from opening since the app bundle isn't signed by Apple.Other solutions I found online require the Xcode generator. However VPKEdit uses generator expressions so it can't use the Xcode generator.
I also edited L67 on
install/_install.cmakesince at this stage the application bundle is still calledvpkedit.app, the file is renamed only when the app bundle is inside the DMG bundle (seeinstall/macos/DMGSetup.scpt:40, I did so since I don't want to change the executable target name to${PROJECT_NAME_PRETTY}insrc/gui/_gui.cmake). It works previously due to the macOS file system being case insensitive (which is probably why theRENAMEatinstall/_install.cmake:56doesn't work but this is a speculation)