Skip to content

install: fix macos code signing #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

install: fix macos code signing #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ function(vpkedit_configure_target TARGET)
endif()
elseif(APPLE)
option(VPKEDIT_MAC_BUNDLE_QT "Bundle Qt into the application bundle for macOS" ON)
option(VPKEDIT_MAC_BUNDLE_ADHOC_SIGN "Ad-hoc sign the macOS application bundle" ON)
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/macOS")
include(MakeICNS)
set(MACOS_ICON "${CMAKE_CURRENT_BINARY_DIR}/logo.icns")
Expand Down
1 change: 1 addition & 0 deletions cmake/macos/SignBundle.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
execute_process(COMMAND codesign --deep -fs - ${CPACK_TEMPORARY_INSTALL_DIRECTORY}/vpkedit.app)
6 changes: 5 additions & 1 deletion install/_install.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ elseif(APPLE)
DESTINATION .)

install(TARGETS ${PROJECT_NAME}_dmx_preview ${PROJECT_NAME}_mdl_preview
DESTINATION "${PROJECT_NAME_PRETTY}.app/Contents/PlugIns/previews")
DESTINATION "${PROJECT_NAME}.app/Contents/PlugIns/previews")

# Deploy Qt into the bundle
if(VPKEDIT_MAC_BUNDLE_QT)
Expand All @@ -73,6 +73,10 @@ elseif(APPLE)
OUTPUT_SCRIPT qt_deploy_script)
install(SCRIPT ${qt_deploy_script})
endif()

if(VPKEDIT_MAC_BUNDLE_ADHOC_SIGN)
set(CPACK_PRE_BUILD_SCRIPTS "${CMAKE_CURRENT_SOURCE_DIR}/cmake/macos/SignBundle.cmake")
endif()
elseif(UNIX)
install(TARGETS ${PROJECT_NAME}cli
DESTINATION "${CMAKE_INSTALL_BINDIR}")
Expand Down