-
Notifications
You must be signed in to change notification settings - Fork 396
fix(microsoft-edge): use same apt source filename as Microsoft post-install script #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
MikeMcC399
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the FACTORY_VERSION and add an entry to the CHANGELOG. Check the CONTRIBUTING document for information.
|
I checked using the following that the PR continues to allow Edge to install and run correctly, and that no warning appears when running cd factory
docker compose build factory --no-cache
docker compose build edge --no-cache
cd test-project
set -a && . ../.env && set +a
docker compose run --build --rm test-factory-all-includeddocker run -it --rm cypress/edgeapt-get update # check no warnings
apt-get upgrade # if offered confirm that microsoft-edge-stable upgrade is successful
microsoft-edge --version |
|
This PR fixes the Edge warning, however it doesn't fix your issue #1404 installing Note also that changes to the factory build process will only change future image builds. The image |
This comment was marked as outdated.
This comment was marked as outdated.
|
I have picked up your commit from this PR and packaged it into PR #1406 that can be published. This PR was incomplete because it did not include a bump to the Thanks for your contribution! Please feel free to open a new issue if there is anything that I have overlooked. |
Read the comment on the linked issue.
We can update our reference once the fixed image is published
That's fine by me. Thanks for reviewing my changes |
|
|
The PR has been merged, so Thanks again for reporting this issue! Due to the fact that it was only a warning, it was being ignored by everybody else. Now, due to your initiative this warning should no longer appear. |
The filename doesn't need a suffix because Microsoft's repo provides all 3 channels1:
Channel stable is established when adding the APT line
Footnotes
https://packages.microsoft.com/repos/edge/pool/main/m/ ↩