Skip to content

Conversation

@marrws
Copy link
Contributor

@marrws marrws commented Aug 22, 2025

The filename doesn't need a suffix because Microsoft's repo provides all 3 channels1:

Channel stable is established when adding the APT line

ℹ️ Should solve #1404

Footnotes

  1. https://packages.microsoft.com/repos/edge/pool/main/m/

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added bug browser: edge Issues related to Microsoft Edge browser labels Aug 23, 2025
Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the FACTORY_VERSION and add an entry to the CHANGELOG. Check the CONTRIBUTING document for information.

@MikeMcC399
Copy link
Collaborator

@marrws

I checked using the following that the PR continues to allow Edge to install and run correctly, and that no warning appears when running apt update.

cd factory
docker compose build factory --no-cache
docker compose build edge --no-cache
cd test-project
set -a && . ../.env && set +a
docker compose run --build --rm test-factory-all-included
docker run -it --rm cypress/edge
apt-get update # check no warnings
apt-get upgrade # if offered confirm that microsoft-edge-stable upgrade is successful
microsoft-edge --version

@MikeMcC399
Copy link
Collaborator

@marrws

This PR fixes the Edge warning, however it doesn't fix your issue #1404 installing jq. For that you need to run apt-get update.

Note also that changes to the factory build process will only change future image builds. The image cypress/included:13.8.1 won't be re-built and re-published by Cypress, although you could yourself build a new image using the cypress/factory build process.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator

@marrws

I have picked up your commit from this PR and packaged it into PR #1406 that can be published.

This PR was incomplete because it did not include a bump to the FACTORY_VERSION or an addition to the changelog.

Thanks for your contribution! Please feel free to open a new issue if there is anything that I have overlooked.

@MikeMcC399 MikeMcC399 closed this Aug 26, 2025
@marrws
Copy link
Contributor Author

marrws commented Aug 26, 2025

@marrws

This PR fixes the Edge warning, however it doesn't fix your issue #1404 installing jq. For that you need to run apt-get update.

Read the comment on the linked issue.

Note also that changes to the factory build process will only change future image builds. The image cypress/included:13.8.1 won't be re-built and re-published by Cypress, although you could yourself build a new image using the cypress/factory build process.

We can update our reference once the fixed image is published

@marrws

I have picked up your commit from this PR and packaged it into PR #1406 that can be published.

This PR was incomplete because it did not include a bump to the FACTORY_VERSION or an addition to the changelog.

Thanks for your contribution! Please feel free to open a new issue if there is anything that I have overlooked.

That's fine by me. Thanks for reviewing my changes

@MikeMcC399
Copy link
Collaborator

@marrws

That's fine by me. Thanks for reviewing my changes

@MikeMcC399
Copy link
Collaborator

@marrws

The PR has been merged, so cypress/factory, cypress/browsers and cypress/included are now all updated with the Edge fix. cypress/base will get updated the next time there is a new release of Node.js 22 LTS.

Thanks again for reporting this issue! Due to the fact that it was only a warning, it was being ignored by everybody else. Now, due to your initiative this warning should no longer appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser: edge Issues related to Microsoft Edge browser bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants