-
Notifications
You must be signed in to change notification settings - Fork 396
fix: use microsoft-edge.list for Edge installation #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
3986462 to
d357f41
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c8d1f35 to
069289a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
069289a to
bcc61b6
Compare
CHROME_VERSION to 140.0.7339.80-1 CHROME_FOR_TESTING_VERSION to 140.0.7339.80
183001d to
89e93e4
Compare
|
@jennifer-shehane / @AtofStryker Please review and merge this pending PR. Thank you! |
30bb4d5 to
06878ec
Compare
AtofStryker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MikeMcC399 sorry for the delay in reviewing this PR. I am running into this issue after building the edge image and bashing into the docker image
It doesn't look like there is microsoft-edge-stable or microsoft-edge installed after running the which command
|
There appears to have been a problem with the connection to the Microsoft archive at the time of your tests. This type of error also occasionally occurs in CI, however since all CI jobs are successful, there can't be any basic problem with the PR.
|
|
I also now have a branch update/debian set up for the Debian 13.1 upgrade. I'll hold back on submitting a PR until this one for Edge is merged, then rebase. Also, if possible, please let me know if there is a Cypress release going ahead today / tomorrow, and in that case I'll also wait for that one to go through and then rebase on that one. |
|
@MikeMcC399 we do plan on releasing today. Would you like me to merge this in prior or after the release? |
Before the release would be better. |
Situation
Installing Microsoft Edge through the
cypress/factoryprocess using the script factory/installScripts/edge/default.sh causes two entries to be placed into/etc/apt/sources.list.dmicrosoft-edge-stable.listThe filename
/etc/apt/sources.list.d/microsoft-edge-stable.listis explicitly generated by the Cypress Edge installation script factory/installScripts/edge/default.sh and the installation process causes it to be populated with:microsoft-edge.listThe filename
/etc/apt/sources.list.d/microsoft-edge.listand contents are generated by thepostinstallscript of the Debian Edge package:Since the non-commented contents of the two files are identical, executing
apt-get updatecauses a warning:Change
Modify factory/installScripts/edge/default.sh to use only the filename
microsoft-edge.list. This allows the Debian Edge package to update the file instead of creating a new one in itspostinstallphase and remediates the warning concerning multiple configurations.In factory/.env make the following updates:
FACTORY_VERSION6.0.16.0.2FACTORY_DEFAULT_NODE_VERSION22.19.0CHROME_VERSION139.0.7258.154-1140.0.7339.80-1CHROME_FOR_TESTING_VERSION139.0.7258.154140.0.7339.80EDGE_VERSION139.0.3405.125-1140.0.3485.54-1FIREFOX_VERSION142.0.1Verification
Reference