[Feature] Add arm option to databricks_node_type instead of graviton
#5028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iton` `graviton` name is AWS specific and could be confusing for Azure users. So deprecated `graviton` and added `arm` attribute instead. Resolves #4128
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the AWS-specific graviton attribute and introduces a more generic arm attribute for the databricks_node_type data source to better support both AWS Graviton and Azure Cobalt ARM-based CPUs.
Key changes:
- Replaces
gravitonwitharmattribute while maintaining backward compatibility - Updates internal API structures to support the new attribute
- Updates default node types for Azure from older to newer generations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/data-sources/node_type.md | Updates documentation to reflect new arm attribute and deprecate graviton |
| clusters/data_node_type.go | Implements new NodeTypeRequest struct with arm attribute and backward compatibility logic |
| clusters/data_node_type_test.go | Updates expected default node type for Azure |
| clusters/clusters_api.go | Updates API calls to use new NodeTypeRequest wrapper structure |
| storage/mounts.go | Updates API calls to use new NodeTypeRequest wrapper structure |
| catalog/resource_sql_table.go | Updates API calls to use new NodeTypeRequest wrapper structure |
| access/resource_sql_permissions.go | Updates API calls to use new NodeTypeRequest wrapper structure |
| NEXT_CHANGELOG.md | Adds changelog entry for the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| return defaultSmallestNodeType(w, request) | ||
| } | ||
| nodeType, err := nodeTypes.Smallest(request) | ||
| // if arm is true, then graviton is true |
There was a problem hiding this comment.
The comment is misleading. It should clarify that this sets Graviton to true when either Arm or Graviton is true, not that 'arm being true makes graviton true'.
Suggested change
| // if arm is true, then graviton is true | |
| // Set Graviton to true if either Arm or Graviton is true |
tanmay-db
approved these changes
Oct 7, 2025
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Oct 15, 2025
## Release v1.92.0 ### Breaking Changes * Remove stale resources/datasources/documentation related to Clean Room services. * databricks\_permissions resource no longer updates permissions on delete. This is to mitigate an issue with incorrect IS\_OWNER being set ([#5096](#5096)) ### New Features and Improvements * Add `arm` option to `databricks_node_type` instead of `graviton` ([#5028](#5028)) * Add `data_quality_monitor` resource and data sources ([#5092](#5092)). * Add `data_quality_refresh` resource and data sources ([#5092](#5092)). * Perform workspace-level permission assignment by `user_name`, `group_name`, or `service_principal_name` ([#5068](#5068)). ### Bug Fixes * Fixed syncing of effective fields in plugin framework implementation of share resource ([#4969](#4969)) * Mark `storage_location` as read-only in `databricks_catalog` ([#5075](#5075)) ### Documentation * Add instructions for migration from deprecated `databricks_catalog_workspace_binding` to `databricks_workspace_binding` ([#5054](#5054)) * Document output attributes in `databricks_storage_credential` ([#5093](#5093)) ### Internal Changes * Bump the Go SDK to v0.86.0 ([#5092](#5092)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
gravitonname is AWS specific and could be confusing for Azure users. So deprecatedgravitonand addedarmattribute instead.Resolves #4128
Tests
make testrun locallydocs/folderNEXT_CHANGELOG.mdfile