Skip to content

refactor(selector): not hiding the first option HTML element anymore #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 78 commits into
base: main
Choose a base branch
from

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Apr 4, 2025

Proposed changes

  • it's inconsistent in between browsers (Safari would still display that option[hidden])
  • it's inconsistent and incorrect for regular select-HTML-elements, as those would actually mark the first option as checked as well, whereas this is actually the selected one (gets transmitted in form submits etc.)
  • In case that somebody would like to use floating labels or placeholder, there should be an option that the users could set to "unselect" all selectable options, or in other words "reset" any other selection. We wouldn't provide this possibility at the moment anyhow.

Resolves #4019

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

it's inconsistent in between browsers and we should only use it for placeholders or floating labels
@mfranzke mfranzke requested a review from nmerget as a code owner April 4, 2025 09:16
@mfranzke mfranzke linked an issue Apr 4, 2025 that may be closed by this pull request
7 tasks
@mfranzke mfranzke self-assigned this Apr 4, 2025
Copy link
Contributor

github-actions bot commented Apr 4, 2025

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Apr 4, 2025
@github-actions github-actions bot added the 🧱components Changes inside components folder label Apr 4, 2025
@mfranzke mfranzke requested review from Copilot and removed request for nmerget April 4, 2025 09:16
@mfranzke mfranzke moved this to 🏗 In development in UX Engineering Team Backlog Apr 4, 2025
@mfranzke mfranzke added the 🐛bug Something isn't working label Apr 4, 2025
Copilot

This comment was marked as outdated.

@mfranzke mfranzke added this to the 2.0.0 milestone Apr 4, 2025
@mfranzke mfranzke changed the title refactor: let's not hide the first element in the select anymore refactor(selector): let's not hide the first element in the select anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first element in the select anymore refactor(selector): let's not hide the first element anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first element anymore refactor(selector): let's not hide the first option anymore Apr 4, 2025
@mfranzke mfranzke changed the title refactor(selector): let's not hide the first option anymore refactor(selector): not hiding the first option anymore Apr 4, 2025
@mfranzke mfranzke modified the milestones: 2.0.0, 2.1.0 Apr 15, 2025
@github-actions github-actions bot added the 📦foundations Changes inside foundations folder label Apr 17, 2025
github-actions bot and others added 21 commits August 14, 2025 11:17
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke enabled auto-merge (squash) August 18, 2025 13:38
@mfranzke mfranzke moved this from 🏗 In development to 👀 In review in UX Engineering Team Backlog Aug 18, 2025
@mfranzke mfranzke removed their assignment Aug 18, 2025
@mfranzke mfranzke added this to the 3.1.0 milestone Aug 19, 2025
@mfranzke mfranzke added this to Roadmap Aug 19, 2025
@mfranzke mfranzke changed the title refactor(selector): not hiding the first option anymore refactor(selector): not hiding the first option HTML element anymore Aug 19, 2025
@mfranzke mfranzke requested a review from Copilot August 19, 2025 16:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the select component to improve browser consistency and form behavior by replacing the hidden placeholder option with a visible CSS-classed option. The changes address Safari-specific display issues and ensure the select component behaves like standard HTML select elements.

Key Changes:

  • Replace hidden attribute with .placeholder CSS class for the first option element
  • Update CSS selectors to target .placeholder class instead of [hidden] attribute
  • Add placeholder props to showcase examples and tests

Reviewed Changes

Copilot reviewed 18 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/components/src/components/select/select.lite.tsx Core component logic updated to use CSS class instead of hidden attribute for placeholder option
packages/components/src/styles/internal/_form-components.scss Updated CSS selector from [hidden] to .placeholder class
packages/components/src/components/select/select.scss Updated CSS selector for placeholder option styling
showcases/shared/select.json Added placeholder properties to all showcase examples
showcases/vue-showcase/src/components/select/Select.vue Fixed placeholder prop binding from exampleName to exampleProps?.placeholder
showcases/react-showcase/src/components/select/index.tsx Updated prop name from children to placeholder
packages/components/src/components/select/index.html Updated HTML examples to use CSS class instead of hidden attribute
packages/components/src/components/select/select.spec.tsx Added value prop to test component
Multiple snapshot files Updated accessibility snapshots to reflect new option structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

<span id={state._placeholderId}>
{props.placeholder ?? props.label}
</span>
<Show when={props.placeholder !== ''}>
Copy link
Preview

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition props.placeholder !== '' will show the placeholder span even when props.placeholder is undefined or null. This should check for truthy values: <Show when={props.placeholder}> to properly handle all falsy cases.

Suggested change
<Show when={props.placeholder !== ''}>
<Show when={props.placeholder}>

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🧱components Changes inside components folder 🍄🆙improvement New feature or request
Projects
Status: No status
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

DBSelect dropdown checkmark on first element
2 participants