Skip to content

refactor(selector): not hiding the first option HTML element anymore #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 78 commits into
base: main
Choose a base branch
from
Open

refactor(selector): not hiding the first option HTML element anymore #4020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
4eb469d
refactor: let's not hide the first element in the select anymore
mfranzke Apr 4, 2025
37c89a2
Update packages/components/src/components/select/select.lite.tsx
mfranzke Apr 4, 2025
392278d
test: updated snapshots
mfranzke Apr 4, 2025
15ba5d5
test: updated snapshots
mfranzke Apr 4, 2025
9b06c2e
refactor: removed those again
mfranzke Apr 4, 2025
207d625
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Apr 4, 2025
5c43e22
test: updated snapshots
mfranzke Apr 4, 2025
417e830
Revert "test: updated snapshots"
mfranzke Apr 4, 2025
ca57f23
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Apr 17, 2025
7e53415
Update DBSelect-should-have-same-aria-snapshot.yaml
mfranzke Apr 17, 2025
fbfa298
Update DBSelect-should-have-same-aria-snapshot.yaml
mfranzke Apr 17, 2025
6e5effe
Update DBSelect-should-have-same-aria-snapshot.yaml
mfranzke Apr 17, 2025
5fca738
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Apr 17, 2025
a4b5e47
test: updated snapshots
mfranzke Apr 17, 2025
4069978
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Apr 18, 2025
3b0056a
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Apr 22, 2025
fb0112b
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Apr 30, 2025
424de71
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke May 13, 2025
33428fb
test: updated snapshot
mfranzke May 13, 2025
4f40561
refactor: updated snapshots
mfranzke May 13, 2025
380494b
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Jun 30, 2025
c801214
auto update snapshots (#4442)
github-actions[bot] Jun 30, 2025
6b36933
test: updated snapshots
mfranzke Jun 30, 2025
df92c1b
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Jul 1, 2025
d7fd0fe
auto update snapshots (#4453)
github-actions[bot] Jul 1, 2025
75f1460
refactor: prettifying
mfranzke Jul 1, 2025
857a387
refactor: corrected aria snapshots
mfranzke Jul 1, 2025
a3cf4d6
refactor: corrected aria snapshots
mfranzke Jul 1, 2025
79f0317
auto update snapshots (#4454)
github-actions[bot] Jul 1, 2025
49ca700
refactor: let's give this a try
mfranzke Jul 1, 2025
e66f32d
auto update snapshots (#4455)
github-actions[bot] Jul 1, 2025
5d74952
test: updated snapshots
mfranzke Jul 1, 2025
25b6398
Merge branch '4019-dbselect-dropdown-checkmark-on-first-element' of h…
mfranzke Jul 1, 2025
e16feed
test: updated snapshots
mfranzke Jul 1, 2025
0e90a51
Revert "refactor: let's give this a try"
mfranzke Jul 1, 2025
e553b4a
Update index.html
mfranzke Jul 1, 2025
f76eb2d
auto update snapshots (#4456)
github-actions[bot] Jul 1, 2025
88cea12
chore: another try
mfranzke Jul 1, 2025
f13410b
Merge branch '4019-dbselect-dropdown-checkmark-on-first-element' of h…
mfranzke Jul 1, 2025
b882086
auto update snapshots (#4457)
github-actions[bot] Jul 1, 2025
3d2dc0c
chore: another try
mfranzke Jul 1, 2025
d93ff31
Merge branch '4019-dbselect-dropdown-checkmark-on-first-element' of h…
mfranzke Jul 1, 2025
5eddf96
Revert "chore: another try"
mfranzke Jul 1, 2025
012cea4
auto update snapshots (#4463)
github-actions[bot] Jul 1, 2025
b850c2d
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Jul 2, 2025
74cbec6
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Jul 10, 2025
a549931
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 14, 2025
ffc361f
refactor: placeholder shouldn't be an empty string, elsewhere check f…
mfranzke Aug 14, 2025
444f02c
refactor: only display placeholder, not label at this place
mfranzke Aug 14, 2025
907741c
refactor: regenerated package lock file
mfranzke Aug 14, 2025
f7d6778
auto update snapshots (#4734)
github-actions[bot] Aug 14, 2025
5e73b39
Update select.lite.tsx
mfranzke Aug 14, 2025
fac4419
fix: setting the placeholder by the children doesn't make any sense a…
mfranzke Aug 14, 2025
8543e46
auto update snapshots (#4738)
github-actions[bot] Aug 14, 2025
ce322e5
fix: setting it by the name instead
mfranzke Aug 14, 2025
4bd0757
refactor: this looks better now
mfranzke Aug 14, 2025
2493832
auto update snapshots (#4739)
github-actions[bot] Aug 14, 2025
aefe5d9
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
551fd36
refactor: optimization
mfranzke Aug 15, 2025
386d871
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
829644b
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
223d710
Merge branch '4019-dbselect-dropdown-checkmark-on-first-element' of h…
mfranzke Aug 15, 2025
e8719b9
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
0eabff8
refactor: let's give this a try
mfranzke Aug 15, 2025
edbb557
auto update snapshots (#4748)
github-actions[bot] Aug 15, 2025
744eeea
Update select.lite.tsx
mfranzke Aug 15, 2025
bfcdf81
auto update snapshots (#4750)
github-actions[bot] Aug 15, 2025
a2e4c6a
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
1f3057c
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
d16ca35
refactor: aligned with base branch
mfranzke Aug 15, 2025
155e83d
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
50163b4
auto update snapshots (#4758)
github-actions[bot] Aug 15, 2025
637903f
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 15, 2025
cdf223e
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke Aug 18, 2025
f6d4340
refactor: we've introduced placeholder property data for this
mfranzke Aug 18, 2025
d0c6b4b
auto update snapshots (#4764)
github-actions[bot] Aug 18, 2025
ed15649
fix(test): temporary fix for vue tests
mfranzke Aug 18, 2025
d1889c6
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
michaelmkraus Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __snapshots__/select/component/chromium/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- text: Label
- combobox "Label":
- option "Test1"
- option "Test1" [selected]
- option "Test2"
- text: Label Description
- text: Description
- status
Binary file modified __snapshots__/select/component/chromium/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions __snapshots__/select/component/firefox/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- text: Label
- combobox "Label":
- option "Test1"
- option "Test1" [selected]
- option "Test2"
- text: Label Description
- text: Description
- status
Binary file modified __snapshots__/select/component/firefox/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions __snapshots__/select/component/mobile-chrome/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- text: Label
- combobox "Label":
- option "Test1"
- option "Test1" [selected]
- option "Test2"
- text: Label Description
- text: Description
- status
Binary file modified __snapshots__/select/component/mobile-chrome/DBSelect-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 25 additions & 0 deletions ...-highContrast/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,157 +3,182 @@
- link "Density"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Functional
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Regular
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Expressive
- status
- link "Variant"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Label Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Option 2"
- status
- link "Show Label"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) True
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "False"
- status
- link "Show Message"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) False
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: True Message
- status
- link "State"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Empty
- status
- text: Label
- combobox "Label":
- option
- option "Filled" [selected]
- option "Option 2"
- status
- link "Validation"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) No validation
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Invalid Invalid Message
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Valid"
- option "Option 2"
- text: Valid Valid message
- status
- link "Disabled"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) False
- status
- text: Label
- combobox "Label" [disabled]:
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "True"
- status
- link "Content"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Text
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Text - Leading Icon
- status
- link "Required"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) False
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "True"
- status
- link "Show Required Asterisk"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) True
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "False"
- status
- link "Examples Floating Label"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Empty
- status
- text: Label
- combobox "Label":
- option
- option "Filled" [selected]
- option "Option 2"
- status
- text: Label
- combobox "Label" [disabled]:
- option
- option "Disabled" [selected]
- option "Option 2"
- status
25 changes: 25 additions & 0 deletions ...case/chromium/should-have-same-aria-snapshot/DBSelect-should-have-same-aria-snapshot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,157 +3,182 @@
- link "Density"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Functional
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Regular
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Expressive
- status
- link "Variant"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Label Above
- status
- text: Label
- combobox "Label":
- option
- option "Floating Label" [selected]
- option "Option 2"
- status
- link "Show Label"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) True
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "False"
- status
- link "Show Message"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) False
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: True Message
- status
- link "State"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Empty
- status
- text: Label
- combobox "Label":
- option
- option "Filled" [selected]
- option "Option 2"
- status
- link "Validation"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) No validation
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Invalid Invalid Message
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Valid"
- option "Option 2"
- text: Valid Valid message
- status
- link "Disabled"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) False
- status
- text: Label
- combobox "Label" [disabled]:
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "True"
- status
- link "Content"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Text
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: Text - Leading Icon
- status
- link "Required"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) False
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "True"
- status
- link "Show Required Asterisk"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) True
- status
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: "False"
- status
- link "Examples Floating Label"
- text: Label
- combobox "Label":
- option [selected]
- option "Option 1"
- option "Option 2"
- text: (Default) Empty
- status
- text: Label
- combobox "Label":
- option
- option "Filled" [selected]
- option "Option 2"
- status
- text: Label
- combobox "Label" [disabled]:
- option
- option "Disabled" [selected]
- option "Option 2"
- status
Loading
Loading