feat: Releasing v4 of DSOMM app #56
Conversation
…ecause the old still exists
vbakke
left a comment
vbakke
left a comment
There was a problem hiding this comment.
Great! Let's discuss this in the meeting coming up 🙂
.github/workflows/main.yml
Outdated
| docker cp yaml:/var/www/html/src/assets/YAML/generated/generated.yaml src/assets/YAML/generated/generated.yaml | ||
| # Commit all changed files back to the repository | ||
| - uses: planetscale/[email protected] | ||
| docker cp yaml:/var/www/html/src/assets/YAML/generated/generated.yaml src/assets/YAML/generated/generated.yaml # TODO: Remove |
There was a problem hiding this comment.
Ref the discussion we had regarding having the generated and input source files in the same folder, @wurstbrot:
What about keeping the source yaml files as they are, and move generated folder to root? Then it is not under src and will be obvious for anyone downloading the project.
/
- src/assets/YAML/**
- generated/
- activities.yaml
- dependency-tree.md
- scripts/
- generateDimensions.php
- ...
(And we don't need to rename /yaml-generation to /scripts, btw. It's just a suggestion to make things more self explanatory. But it will have a side-effect on trigering the php file.)
There was a problem hiding this comment.
Does silence imply consent, @wurstbrot?
I'll move the generated folder up to root 🙂
Removed unused team and evidence references. Not part of the the new v4 `activities.yaml`
|
|
||
| $errorMsg = array(); | ||
| $implementationReferenceFile = "src/assets/YAML/default/implementations.yaml"; | ||
| $metadata = readYaml("src/assets/YAML/meta.yaml"); |
There was a problem hiding this comment.
Ah, I just saw your comment about compatibility, @wurstbrot. We still need these lines to be compatible with generated.yaml. But they can be removed for activities.yaml.
There was a problem hiding this comment.
If this PR is for v4 relase, the meta.yaml is no longer needed in the generation script, as teams are no longer produce in the files.
Preparing for major release
Improved Usage documentation
Adopt the new filename `model.yaml`
feat: add activties.yaml with new breaking format, not breaking now because the old still exists
After yaml-generation run, the
activties.yamlhas the new header whilegenerated.yamlis as it was (for compability)