Skip to content

Merge to Live #35764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 19, 2025
Merged

Merge to Live #35764

merged 24 commits into from
Jul 19, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 17, 2025

[AUTOMATED]


Internal previews

📄 File 🔗 Preview link
aspnetcore/mvc/views/razor.md aspnetcore/mvc/views/razor

twsouthwick and others added 22 commits July 14, 2025 11:29
This change adds more detail and consolidates existing topics to create
a more prescriptive and helpful set of options for developers looking to
migration their ASP.NET Framework to Core applications.

Main things included in this update are:

- Consolidated a topics that were logically connected into a single
  document
- Added some basic decision trees for developers to understand what is
  most likely to be useful to them
- Updated the initial landing page to provide a better overview of what
  challenges they may encounter as they start a migration
- Updated the setup instructions to align with the current state of
  things
Fixed date to required format with two digits.
Fixed ms.date format which requires 2 digit month
Just updated ms.date to current since file was significantly updated.
Expand ASP.NET Framework to Core migration
@wadepickett
Copy link
Contributor

wadepickett commented Jul 17, 2025

@guardrex,

This merge to live failure seems odd. I only see warnings related to some blazor PR's that you were likely on, and then just suggestions for one I helped review for migration:

Details on link below. Any thoughts on which was tripping up the live merge?

https://buildapi.docs.microsoft.com/Output/PullRequest/332f35cd-658d-4914-0f85-907e40ee89f0/202507172030150316-35764/BuildReport?accessString=dc1bf01f5458fc6ab93a98f77202a5698d9aad186ab3db52d7329bb7d1460a64

cc: @tdykstra

@guardrex
Copy link
Collaborator

Probably unrelated but it's worth mentioning again, you didn't squash Taylor's PR before merging it to main. Merging without squashing clutters the repo's history and can make it hard to see where content was modified. Theoretically, it can make it more difficult to track down or manage commit problems.

Let's try closing and re-opening first. I'll do that now, which I expect will fail. Next, I'd suggest reverting Taylor's PR, which seems to have introduced the problem. If that works, try to troubleshoot the build of that PR, and perhaps squashing it will help. Anyway ... let's see what happens with a close/open here first ...............

@guardrex guardrex closed this Jul 17, 2025
@guardrex guardrex reopened this Jul 17, 2025
@guardrex
Copy link
Collaborator

That went about how I expected! 😆

I'll go revert Taylor's PR now. Stand-by .........

@wadepickett
Copy link
Contributor

Probably unrelated but it's worth mentioning again, you didn't squash Taylor's PR before merging it to main. Merging without squashing clutters the repo's history and can make it hard to see where content was modified. Theoretically, it can make it more difficult to track down or manage commit problems.

Let's try closing and re-opening first. I'll do that now, which I expect will fail. Next, I'd suggest reverting Taylor's PR, which seems to have introduced the problem. If that works, try to troubleshoot the build of that PR, and perhaps squashing it will help. Anyway ... let's see what happens with a close/open here first ...............

It was worth mentioning again. I completely forgot about squashing his PR after I finished fixing a few things!

@twsouthwick
Copy link
Member

FYI you can set branch policies to force squash merges to specific branches.

@guardrex
Copy link
Collaborator

guardrex commented Jul 18, 2025

@danroth27 said he was going to do that for the main branch.

It's probably also a good idea to prevent squashing for the live branch at the same time.

@twsouthwick
Copy link
Member

squashing from prs->main is a good idea. I think you'll cause problems if you squash main->live

@guardrex
Copy link
Collaborator

guardrex commented Jul 18, 2025

That's been the rule here from day one of the repo. Wade is new and still getting the hang of our 10,000 repo rules and conventions. 😆

@guardrex
Copy link
Collaborator

No 🎲🎲! ... but that's ok.

It looks like the broken API cross-links are the problem. I sent an internal email on it. I think at this point, we need to hear back on where that API went. I don't think it's actually bad API (i.e., bad cross-refs/xrefs). I think that API was inadvertently knocked out.

@danroth27
Copy link
Member

danroth27 commented Jul 18, 2025

FYI you can set branch policies to force squash merges to specific branches.

@twsouthwick I haven't found a way to do this for specific branches. If you could show me how, that would be great!

@guardrex

This comment was marked as outdated.

@guardrex

This comment was marked as outdated.

@guardrex
Copy link
Collaborator

guardrex commented Jul 18, 2025

Even better, @danroth27 ... It's built in now. The following screenshot is from the Blazor sample repo settings ....

image

Only select squash ...

image

... and then the live branch only gets the "Merge" option with a separate rule.

@guardrex
Copy link
Collaborator

All of the warnings are focused on the MIA API now, which are under discussion offline. I'll go ahead and merge this.

@guardrex guardrex merged commit 66ac7d4 into live Jul 19, 2025
3 of 4 checks passed
@guardrex guardrex mentioned this pull request Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants