Skip to content

Fix a small divide by zero error in PointToFramebuffer #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

Fix a small divide by zero error in PointToFramebuffer #750

merged 1 commit into from
Jan 5, 2022

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Jan 5, 2022

Noticed this when adding a Silk.NET backend to Trains.NET.

@Perksey Perksey added bug Something isn't working area-Maths labels Jan 5, 2022
@Perksey Perksey added this to the 2.X milestone Jan 5, 2022
@Perksey Perksey requested a review from a team as a code owner January 5, 2022 18:39
@Perksey Perksey enabled auto-merge (squash) January 5, 2022 18:41
HurricanKai
HurricanKai approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that's ugly but sure

@Perksey Perksey merged commit 89f5be9 into main Jan 5, 2022
@Perksey Perksey deleted the hotfix/pointtoframebuffer branch January 5, 2022 19:20
@Perksey
Copy link
Member Author

Perksey commented Jan 5, 2022

XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HurricanKai HurricanKai HurricanKai approved these changes

Assignees
No one assigned
Labels
area-Maths bug Something isn't working
Projects
None yet
Milestone
2.X
Development

Successfully merging this pull request may close these issues.
2 participants
@Perksey @HurricanKai