Skip to content

Fix a small divide by zero error in PointToFramebuffer #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Fix a small divide by zero error in PointToFramebuffer #750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Windowing/Silk.NET.Windowing.Common/Internals/ViewImplementationBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ public Vector2D<int> PointToFramebuffer(Vector2D<int> point)
Unsafe.As<int, Vector2D<int>>(ref framebufferSizeElements[0]) = FramebufferSize;
var framebufferSize = new Vector<int>(framebufferSizeElements);
Span<int> sizeElements = stackalloc int[Vector<int>.Count];
// HACK: Avoid divide by zero errors
sizeElements[2..].Fill(1);
Unsafe.As<int, Vector2D<int>>(ref sizeElements[0]) = Size;
var size = new Vector<int>(sizeElements);
Span<int> pointElements = stackalloc int[Vector<int>.Count];
Expand All @@ -295,6 +297,11 @@ public Vector2D<int> PointToFramebuffer(Vector2D<int> point)
Unsafe.As<int, Vector2D<int>>(ref a[0]) = FramebufferSize;
Unsafe.As<int, Vector2D<int>>(ref a[c]) = Size;
Unsafe.As<int, Vector2D<int>>(ref a[c * 2]) = point;

// HACK: Avoid divide by zero errors
for (var i = c + 2; i < c * 2; i++)
a[i] = 1;

var framebufferSize = new Vector<int>(a, 0);
var size = new Vector<int>(a, c);
var thePoint = new Vector<int>(a, c * 2);
Expand Down