Update scripts to use the new Quality mappings to urls #10479

radical · 2025-07-17T01:48:46Z

Key Changes

1. Quality Level Behavior

dev: Downloads latest development builds from the main branch
staging: Downloads release candidate builds (rc/daily)
ga: Downloads generally available release builds (ga/daily)
Default: staging quality is used when no quality is specified

2. Updated URL Mappings for Quality Levels

PowerShell Script (get-aspire-cli.ps1):
- dev quality now maps to: https://aka.ms/dotnet/9/aspire/daily
- staging quality now maps to: https://aka.ms/dotnet/9/aspire/rc/daily
- ga quality now maps to: https://aka.ms/dotnet/9/aspire/ga/daily
Bash Script (get-aspire-cli.sh):
- Updated with corresponding URL mappings to match PowerShell script
- Consistent quality-to-URL mapping across both script implementations

3. Support for -WhatIf and --dry-run

This will be useful for testing

4. Code Quality Improvements

The code has been made more idiomatic in many ways:

Better PowerShell coding practices and conventions
Improved error handling patterns
Enhanced cross-platform compatibility
More robust parameter validation
Cleaner function organization and separation of concerns

…r -WhatIf in ps1, and --dry-run in sh

Co-authored-by: Copilot <[email protected]>

radical · 2025-07-18T09:13:27Z

Hiding whitespace changes is useful for the review.

Copilot

Pull Request Overview

This PR updates the Aspire CLI download scripts to support new quality-based URL mappings and adds dry-run functionality. The changes standardize the URL structure across PowerShell and Bash scripts, with staging becoming the default quality level instead of daily.

Key changes:

Updated URL mappings for quality levels (dev, staging, ga) to use aka.ms URLs
Added --dry-run and -WhatIf support for testing without performing actual operations
Improved error handling, parameter validation, and PowerShell coding practices

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
eng/scripts/get-aspire-cli.sh	Updated Bash script with new quality-based URL mappings, added dry-run support, and improved error handling
eng/scripts/get-aspire-cli.ps1	Enhanced PowerShell script with configuration-based URL construction, WhatIf support, and better PowerShell practices
eng/scripts/README.md	Updated documentation to reflect new quality options and default values

eng/scripts/get-aspire-cli.ps1

Copilot · 2025-07-18T09:14:30Z

eng/scripts/get-aspire-cli.ps1


-    $expectedChecksum = (Get-Content $ChecksumFile -Raw).Trim().ToLower()
-    $actualChecksum = (Get-FileHash -Path $ArchiveFile -Algorithm SHA512).Hash.ToLower()
+    $expectedChecksum = (Get-Content $ChecksumFile -Raw -ErrorAction Stop).Trim().ToLowerInvariant()


Consider adding validation to ensure the checksum file contains valid content before processing. An empty or malformed checksum file could cause unexpected behavior.

Suggested change

$expectedChecksum = (Get-Content $ChecksumFile -Raw -ErrorAction Stop).Trim().ToLowerInvariant()

$expectedChecksum = (Get-Content $ChecksumFile -Raw -ErrorAction Stop).Trim().ToLowerInvariant()

# Validate the checksum content

if (-not $expectedChecksum) {

throw "Checksum file '$ChecksumFile' is empty. Please provide a valid checksum file."

}

if ($expectedChecksum -notmatch '^[a-f0-9]{128}$') {

throw "Checksum file '$ChecksumFile' contains invalid content. Expected a 128-character hexadecimal string."

}

eng/scripts/get-aspire-cli.ps1

eng/scripts/get-aspire-cli.sh

Co-authored-by: Copilot <[email protected]>

davidfowl · 2025-07-18T14:31:04Z

Verified so far on MacOS. Are we going to change the default quality level in each branch?

DeagleGross · 2025-07-18T14:47:32Z

works for windows

DeagleGross

tested; would be great if others can test on linux/macos

davidfowl · 2025-07-18T15:07:49Z

I did 😄

davidfowl · 2025-07-18T15:08:12Z

Testing in a codespace now (for linux)

davidfowl · 2025-07-18T15:08:32Z

@DeagleGross did you try different staging and dev?

davidfowl · 2025-07-18T15:32:31Z

Works on linux! (in bash)

DeagleGross · 2025-07-18T16:52:38Z

@davidfowl yep, works for staging and dev

eng/scripts/get-aspire-cli.ps1

radical · 2025-07-22T05:16:17Z

/backport to release/9.4

github-actions · 2025-07-22T05:16:25Z

Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16435355366

github-actions · 2025-07-22T05:16:29Z

@radical backporting to "release/9.4" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update scripts to use the new Quality mappings to urls
Applying: Rename qualities to dev, staging, and ga. And make staging the default
Applying: Cleanup the scripts making the ps1 more idiomatic. And add support for -WhatIf in ps1, and --dry-run in sh
Applying: Update eng/scripts/get-aspire-cli.ps1
Applying: Fix parameter validation
Applying: Update eng/scripts/get-aspire-cli.ps1
Applying: Update eng/scripts/get-aspire-cli.sh
Applying: rename ga to release
Applying: change default quality to release
Applying: Add examples of using the script with arguments
Using index info to reconstruct a base tree...
M	docs/using-latest-daily.md
Falling back to patching base and 3-way merge...
Auto-merging docs/using-latest-daily.md
CONFLICT (content): Merge conflict in docs/using-latest-daily.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0010 Add examples of using the script with arguments
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

## Key Changes ### 1. **Quality Level Behavior** - **`dev`**: Downloads latest development builds from the `main` branch - **`staging`**: Downloads release candidate builds (rc/daily) - **`ga`**: Downloads generally available release builds (ga/daily) - **Default**: `staging` quality is used when no quality is specified ### 2. **Updated URL Mappings for Quality Levels** - **PowerShell Script (`get-aspire-cli.ps1`)**: - `dev` quality now maps to: `https://aka.ms/dotnet/9/aspire/daily` - `staging` quality now maps to: `https://aka.ms/dotnet/9/aspire/rc/daily` - `ga` quality now maps to: `https://aka.ms/dotnet/9/aspire/ga/daily` - **Bash Script (`get-aspire-cli.sh`)**: - Updated with corresponding URL mappings to match PowerShell script - Consistent quality-to-URL mapping across both script implementations ### 3. **Support for -WhatIf and --dry-run** - This will be useful for testing ### 4. **Code Quality Improvements** The code has been made more idiomatic in many ways: - Better PowerShell coding practices and conventions - Improved error handling patterns - Enhanced cross-platform compatibility - More robust parameter validation - Cleaner function organization and separation of concerns Co-authored-by: Copilot <[email protected]> (cherry picked from commit a5d2813)

Update scripts to use the new Quality mappings to urls

a85a274

radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-cli labels Jul 17, 2025

radical added 3 commits July 18, 2025 03:26

Merge remote-tracking branch 'origin/main' into script-update

848e4e5

Rename qualities to dev, staging, and ga. And make staging the default

7864940

Cleanup the scripts making the ps1 more idiomatic. And add support fo…

0835f21

…r -WhatIf in ps1, and --dry-run in sh

radical marked this pull request as ready for review July 18, 2025 08:52

radical requested review from Copilot, davidfowl, DamianEdwards and joperezr July 18, 2025 08:52

radical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 18, 2025

This comment was marked as outdated.

Sign in to view

radical and others added 2 commits July 18, 2025 04:54

Update eng/scripts/get-aspire-cli.ps1

8bfe1d6

Co-authored-by: Copilot <[email protected]>

Fix parameter validation

b50aaa4

radical requested a review from Copilot July 18, 2025 09:13

Copilot AI reviewed Jul 18, 2025

View reviewed changes

radical and others added 2 commits July 18, 2025 05:16

Update eng/scripts/get-aspire-cli.ps1

26fecc4

Co-authored-by: Copilot <[email protected]>

Update eng/scripts/get-aspire-cli.sh

743832c

Co-authored-by: Copilot <[email protected]>

davidfowl added this to the 9.4 milestone Jul 18, 2025

DeagleGross approved these changes Jul 18, 2025

View reviewed changes

joperezr reviewed Jul 18, 2025

View reviewed changes

eng/scripts/get-aspire-cli.ps1 Outdated Show resolved Hide resolved

rename ga to release

c07dace

radical mentioned this pull request Jul 18, 2025

Change the aka.ms "latest" link so that we can customize it depending on the branch that is producing the build. #9922

Closed

1 task

radical added 3 commits July 18, 2025 16:32

change default quality to release

6543736

Merge remote-tracking branch 'origin/main' into script-update

aa6ed74

Add examples of using the script with arguments

3916109

radical merged commit a5d2813 into dotnet:main Jul 18, 2025
276 checks passed

radical deleted the script-update branch July 18, 2025 20:56

radical mentioned this pull request Jul 22, 2025

[release/9.4] Backporting a few get-aspire-cli script PRs #10586

Merged

github-actions bot locked and limited conversation to collaborators Aug 21, 2025

-    $expectedChecksum = (Get-Content $ChecksumFile -Raw -ErrorAction Stop).Trim().ToLowerInvariant()
+    $expectedChecksum = (Get-Content $ChecksumFile -Raw -ErrorAction Stop).Trim().ToLowerInvariant()
+    # Validate the checksum content
+    if (-not $expectedChecksum) {
+        throw "Checksum file '$ChecksumFile' is empty. Please provide a valid checksum file."
+    }
+    if ($expectedChecksum -notmatch '^[a-f0-9]{128}$') {
+        throw "Checksum file '$ChecksumFile' contains invalid content. Expected a 128-character hexadecimal string."
+    }

Update scripts to use the new Quality mappings to urls #10479

Update scripts to use the new Quality mappings to urls #10479

Uh oh!

Conversation

radical commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes

1. Quality Level Behavior

2. Updated URL Mappings for Quality Levels

3. Support for -WhatIf and --dry-run

4. Code Quality Improvements

Uh oh!

This comment was marked as outdated.

Uh oh!

radical commented Jul 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidfowl commented Jul 18, 2025

Uh oh!

DeagleGross commented Jul 18, 2025

Uh oh!

DeagleGross left a comment

Choose a reason for hiding this comment

Uh oh!

davidfowl commented Jul 18, 2025

Uh oh!

davidfowl commented Jul 18, 2025

Uh oh!

davidfowl commented Jul 18, 2025

Uh oh!

davidfowl commented Jul 18, 2025

Uh oh!

DeagleGross commented Jul 18, 2025

Uh oh!

Uh oh!

Uh oh!

radical commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

Uh oh!

radical commented Jul 17, 2025 •

edited

Loading