Move hardcoded cli strings to resx #10504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request moves hardcoded CLI strings to resource files (.resx) to enable proper localization support. The changes remove inline English strings from the CLI commands and interaction service, replacing them with resource string lookups.
Key changes:
- Replaced hardcoded strings in RunCommand and ExecCommand with resource string references
- Updated ConsoleInteractionService to use localized strings for version update notifications
- Added new resource entries and updated existing ones across all localization files
- Modified translation states to reflect the updated source strings
Reviewed Changes
Copilot reviewed 45 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Cli/Commands/RunCommand.cs | Replace hardcoded strings with RunCommandStrings resource references |
| src/Aspire.Cli/Commands/ExecCommand.cs | Replace hardcoded strings with ExecCommandStrings resource references |
| src/Aspire.Cli/Interaction/ConsoleInteractionService.cs | Replace hardcoded strings with InteractionServiceStrings resource references |
| src/Aspire.Cli/Resources/*.resx | Add new resource entries for ConnectingToAppHost, Running, StoppingAppHost, and version notification strings |
| src/Aspire.Cli/Resources/xlf/*.xlf | Update all localization files with new resource entries and modified translation states |
Files not reviewed (3)
- src/Aspire.Cli/Resources/ExecCommandStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/InteractionServiceStrings.Designer.cs: Language not supported
- src/Aspire.Cli/Resources/RunCommandStrings.Designer.cs: Language not supported
danmoseley
reviewed
Jul 17, 2025
| @@ -200,4 +200,12 @@ | |||
| <data name="WaitingForDebuggerToAttachToAppHost" xml:space="preserve"> | |||
| <value>Waiting for debugger to attach to app host process</value> | |||
| </data> | |||
| <data name="NewDashboardVersionAvailable" xml:space="preserve"> | |||
There was a problem hiding this comment.
this resource name seems wrong. NewCLIVersionAvailable? And below, MoreInfoNewCLIVersion?
danmoseley
approved these changes
Jul 17, 2025
eerhardt
approved these changes
Jul 17, 2025
|
I assume this is not 9.4 as it is likely too late to get localization anyway. |
# Conflicts: # src/Aspire.Cli/Resources/ExecCommandStrings.Designer.cs
# Conflicts: # src/Aspire.Cli/Resources/ExecCommandStrings.Designer.cs # src/Aspire.Cli/Resources/ExecCommandStrings.resx # src/Aspire.Cli/Resources/RunCommandStrings.Designer.cs # src/Aspire.Cli/Resources/RunCommandStrings.resx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate