-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Attributed metrics module and skeleton #6887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmonfortep
wants to merge
10
commits into
develop
Choose a base branch
from
feature/cristian/attributed_metrics_module
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3309dae to
54292a7
Compare
cmonfortep
commented
Oct 3, 2025
| eventRepository.getEventStats(eventName, days) | ||
| } | ||
|
|
||
| // TODO: Pending adding default attributed metrics and removing default prefix from pixel names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will happen on future PRs
54292a7 to
fe91bc1
Compare
e6b6bc4 to
831e0ec
Compare
40 tasks
831e0ec to
c8c63fb
Compare
3 tasks
marcosholgado
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few comments
...d-metrics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/AttributedMetricsState.kt
Outdated
Show resolved
Hide resolved
...impl/src/main/java/com/duckduckgo/app/attributed/metrics/store/AttributedMetricsDateUtils.kt
Outdated
Show resolved
Hide resolved
...ttributed-metrics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/store/EventDao.kt
Outdated
Show resolved
Hide resolved
0602cd7 to
1e2a8db
Compare
1e2a8db to
8c38c24
Compare
This was referenced Oct 15, 2025
9877907 to
a93f92a
Compare
38 tasks
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1211650854212283?focus=true ### Description Add getTag(): String to AttributedMetric ### Steps to test this PR N/A ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
a93f92a to
a79e076
Compare
16 tasks
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1211500171306010?focus=true
Description
Scope
Steps to test this PR
While testing this PR you need to add the following in your logcat filter:
tag~:"AttributedMetrics"Feature 1
New install detected, attributed metrics activeClient status running: true...attributedMetricsFFPrivacy config downloaded, attributed metrics enabled: false(that should disable the client)Client status running: false -> isActive: true, isEnabled: false...Feature 2
App reinstall detected, attributed metrics will not be activeClient status running: false -> isActive: false, isEnabled: true...UI changes