Adding retention attributed metric #6955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
3 tasks
15 tasks
marcosholgado
approved these changes
Oct 20, 2025
| ) : AttributedMetric, AtbLifecyclePlugin { | ||
|
|
||
| companion object { | ||
| private const val PIXEL_NAME_FIRST_MONTH = "user_retention_week" |
There was a problem hiding this comment.
nit: naming? says first month but the name is retention week?
| appCoroutineScope.launch(dispatcherProvider.io()) { | ||
| if (oldAtb == newAtb) { | ||
| logcat(tag = "AttributedMetrics") { | ||
| "RetentionFirstMonth: Skip emitting atb not changed" |
| } | ||
| if (shouldSendPixel().not()) { | ||
| logcat(tag = "AttributedMetrics") { | ||
| "RetentionFirstMonth: Skip emitting, outside window" |
cmonfortep
force-pushed
the
feature/cristian/search_attributed_metric
branch
from
28ebece to
90dafbc
Compare
cmonfortep
force-pushed
the
feature/cristian/retention_attributed_metric
branch
from
7c10354 to
8763abc
Compare
38 tasks
cmonfortep
force-pushed
the
feature/cristian/search_attributed_metric
branch
from
90dafbc to
a8eb8a7
Compare
cmonfortep
force-pushed
the
feature/cristian/retention_attributed_metric
branch
from
8763abc to
8f0cbda
Compare
This was referenced Oct 29, 2025
cmonfortep
force-pushed
the
feature/cristian/search_attributed_metric
branch
from
a8eb8a7 to
efb097e
Compare
cmonfortep
force-pushed
the
feature/cristian/retention_attributed_metric
branch
from
8f0cbda to
7c167da
Compare
cmonfortep
force-pushed
the
feature/cristian/search_attributed_metric
branch
from
efb097e to
287bc5e
Compare
cmonfortep
force-pushed
the
feature/cristian/retention_attributed_metric
branch
from
7c167da to
90451f9
Compare
cmonfortep
force-pushed
the
feature/cristian/search_attributed_metric
branch
from
287bc5e to
77f3862
Compare
cmonfortep
force-pushed
the
feature/cristian/retention_attributed_metric
branch
from
90451f9 to
d238a5c
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382557175160?focus=true ### Description Adds ad clicks attributed metric as per specs in https://app.asana.com/1/137249556945/project/1206716555947156/task/1211301604929610?focus=true ### Steps to test this PR While testing this PR you need to add the following in your logcat filter: `tag~:"AttributedMetrics"` _Feature 1_ - [x] We need fresh install (including removing DDG folder in file system) - [x] Open the app - [x] wait until "skip onboarding" appears - [x] After downloading privacy config and atb init, you should see `Client status running: true -> isActive: true, isEnabled: true` - [x] Skip onboarding, and go to the browser - [x] Perform search like "hotels in vietnam" - [x] click the first ad - [x] Ensure in logs `Collected event ad_click` - [x] Go to settings -> `Attributed Metrics Dev Settings` - [x] Click on "Add Ad clicks Events" so we add some test data - [x] Update installation date with 2d ago (and click save) - [x] Close the app, open it again (or fire button) - [x] Perform search like "restaurants in vietnam" - [x] Click first ad - [x] Ensure `Fired pixel user_average_ad_clicks_past_week` ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
cmonfortep
merged commit b870ae3
into
feature/cristian/search_attributed_metric
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382557175157?focus=true
Description
Adds retention metric as per specs in https://app.asana.com/1/137249556945/project/1206716555947156/task/1211301604929607?focus=true
Steps to test this PR
While testing this PR you need to add the following in your logcat filter:
tag~:"AttributedMetrics"Feature 1
Client status running: true -> isActive: true, isEnabled: trueAttributed Metrics Dev Settingsv502-1(and click save)Fired pixel user_retention_week with params {count=1}v502-1(and click save)Fired pixel user_retention_week with params {count=2}v502-1(and click save)Fired pixel user_retention_month with params {count=1}UI changes