Skip to content

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Nov 4, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382919613023?focus=true

Description

Remove default params from attributed metrics pixels.
Pixel renaming to use attributed_metric as prefix.
Add version as metric param (representing bucket version).
Includes sending origin, or install date as fallback.
Removes stored data outside monitoring window.

Steps to test this PR

This will be tested by privacy team to ensure:

  • we don't include default params
  • we strip form factor from pixel (no phone / tablet)
  • we include origin or install date
  • buckets include their version

Go to PrivacyFeatureName class and replace url by https://api.jsonblob.com/019a4fb1-89b3-7971-8c77-ab77969a5874
So it can be smoke tested optionally, to validate those parts.

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep cmonfortep force-pushed the feature/cristian/remove_form_factor_pixels branch from f332376 to a7d81d6 Compare November 4, 2025 13:43
@cmonfortep cmonfortep marked this pull request as ready for review November 4, 2025 13:46
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from c7ecaac to b63c936 Compare November 4, 2025 13:48
@cmonfortep cmonfortep force-pushed the feature/cristian/remove_form_factor_pixels branch from a7d81d6 to a0665e4 Compare November 4, 2025 13:48
@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from b63c936 to dc606a2 Compare November 4, 2025 14:11
@cmonfortep cmonfortep force-pushed the feature/cristian/remove_form_factor_pixels branch 2 times, most recently from 3c6096a to 9cb55ef Compare November 4, 2025 17:13
@cmonfortep cmonfortep changed the title Remove default params on attributed metrics Support privacy specs on attributed metrics Nov 4, 2025
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonfortep cmonfortep force-pushed the feature/cristian/sync_attributed_metric branch from dc606a2 to 768b630 Compare November 6, 2025 12:06
@cmonfortep cmonfortep force-pushed the feature/cristian/remove_form_factor_pixels branch from 9cb55ef to dc35845 Compare November 6, 2025 12:06
@cmonfortep cmonfortep merged commit 4e9a202 into feature/cristian/sync_attributed_metric Nov 6, 2025
5 of 6 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/remove_form_factor_pixels branch November 6, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants