-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support privacy specs on attributed metrics #7053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmonfortep
merged 1 commit into
feature/cristian/sync_attributed_metric
from
feature/cristian/remove_form_factor_pixels
Nov 6, 2025
Merged
Support privacy specs on attributed metrics #7053
cmonfortep
merged 1 commit into
feature/cristian/sync_attributed_metric
from
feature/cristian/remove_form_factor_pixels
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2025
Contributor
Author
cmonfortep
commented
Nov 4, 2025
browser-api/src/main/java/com/duckduckgo/browser/api/referrer/AppReferrer.kt
Show resolved
Hide resolved
f332376 to
a7d81d6
Compare
c7ecaac to
b63c936
Compare
a7d81d6 to
a0665e4
Compare
b63c936 to
dc606a2
Compare
3c6096a to
9cb55ef
Compare
marcosholgado
approved these changes
Nov 5, 2025
Contributor
marcosholgado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dc606a2 to
768b630
Compare
9cb55ef to
dc35845
Compare
4e9a202
into
feature/cristian/sync_attributed_metric
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382919613023?focus=true
Description
Remove default params from attributed metrics pixels.
Pixel renaming to use
attributed_metricas prefix.Add version as metric param (representing bucket version).
Includes sending origin, or install date as fallback.
Removes stored data outside monitoring window.
Steps to test this PR
This will be tested by privacy team to ensure:
Go to
PrivacyFeatureNameclass and replace url byhttps://api.jsonblob.com/019a4fb1-89b3-7971-8c77-ab77969a5874So it can be smoke tested optionally, to validate those parts.
UI changes