-
Notifications
You must be signed in to change notification settings - Fork 28
Get expanded performance results #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonathanKingston
wants to merge
8
commits into
main
Choose a base branch
from
jkt/extendedPerformanceResults
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 02 Oct 2025 22:28:50 GMT Android
File has changed Apple
File has changed Integration
File has changed Windows
File has changed |
shakyShane
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/414235014887631/task/1211309170962125?focus=true
Description
expandedPerformanceMetricsResult
Testing Steps
expandedPerformanceMetricsResult
npm i github:duckduckgo/content-scope-scripts#ff164dd9bc074de381a48c28115728ff5ddb3ba3
(this will update below in the comment if we push more).npm run build-content-scope-scripts
in the apple repo.Checklist
Please tick all that apply:
Note
Adds expanded performance metrics (LCP, navigation, sizes, etc.) collection and messaging, gated by feature flags and included in breakage reports when enabled.
injected/src/features/breakage-reporting/utils.js
):getExpandedPerformanceMetrics
with error handling; gathers navigation timings, paint (incl. FCP), awaits LCP, network timings, sizes, resource stats, and metadata.waitForLCP
to observelargest-contentful-paint
with timeout.PerformanceMetrics
(injected/src/features/performance-metrics.js
):expandedPerformanceMetricsResult
whenexpandedPerformanceMetricsOnLoad
is enabled; skips whenisBeingFramed()
.BreakageReporting
(injected/src/features/breakage-reporting.js
):expandedPerformanceMetrics
tobreakageReportResult
whenexpandedPerformanceMetrics
is enabled.Written by Cursor Bugbot for commit f3f4fa8. This will update automatically on new commits. Configure here.