-
Notifications
You must be signed in to change notification settings - Fork 29
Get expanded performance results #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
74502ad
Get expanded performance results
jonathanKingston 26a9061
Shorthand lint fix
jonathanKingston 1dabda4
lint fix
jonathanKingston 933620c
Remove listener
jonathanKingston 527b3f1
Simplify breakage report. Don't trigger expanded on frame
jonathanKingston 873e5fb
Resolve LCP if exists
jonathanKingston ecc1036
Disable lint
jonathanKingston f3f4fa8
Call on load
jonathanKingston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,23 @@ | ||
import ContentFeature from '../content-feature'; | ||
import { getJsPerformanceMetrics } from './breakage-reporting/utils.js'; | ||
import { getExpandedPerformanceMetrics, getJsPerformanceMetrics } from './breakage-reporting/utils.js'; | ||
|
||
export default class BreakageReporting extends ContentFeature { | ||
init() { | ||
this.messaging.subscribe('getBreakageReportValues', () => { | ||
const isExpandedPerformanceMetricsEnabled = this.getFeatureSettingEnabled('expandedPerformanceMetrics', 'enabled'); | ||
this.messaging.subscribe('getBreakageReportValues', async () => { | ||
const jsPerformance = getJsPerformanceMetrics(); | ||
const referrer = document.referrer; | ||
|
||
this.messaging.notify('breakageReportResult', { | ||
const result = { | ||
jsPerformance, | ||
referrer, | ||
}); | ||
}; | ||
if (isExpandedPerformanceMetricsEnabled) { | ||
const expandedPerformanceMetrics = await getExpandedPerformanceMetrics(); | ||
if (expandedPerformanceMetrics.success) { | ||
result.expandedPerformanceMetrics = expandedPerformanceMetrics.metrics; | ||
} | ||
} | ||
this.messaging.notify('breakageReportResult', result); | ||
}); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,35 @@ | ||
import ContentFeature from '../content-feature'; | ||
import { getJsPerformanceMetrics } from './breakage-reporting/utils.js'; | ||
import { getExpandedPerformanceMetrics, getJsPerformanceMetrics } from './breakage-reporting/utils.js'; | ||
import { isBeingFramed } from '../utils.js'; | ||
|
||
export default class PerformanceMetrics extends ContentFeature { | ||
init() { | ||
this.messaging.subscribe('getVitals', () => { | ||
const vitals = getJsPerformanceMetrics(); | ||
this.messaging.notify('vitalsResult', { vitals }); | ||
}); | ||
|
||
// If the document is being framed, we don't want to collect expanded performance metrics | ||
if (isBeingFramed()) return; | ||
|
||
// If the feature is enabled, we want to collect expanded performance metrics | ||
if (this.getFeatureSettingEnabled('expandedPerformanceMetricsOnLoad', 'enabled')) { | ||
this.waitForPageLoad(() => { | ||
this.triggerExpandedPerformanceMetrics(); | ||
}); | ||
jonathanKingston marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
|
||
waitForPageLoad(callback) { | ||
if (document.readyState === 'complete') { | ||
callback(); | ||
} else { | ||
window.addEventListener('load', callback, { once: true }); | ||
} | ||
} | ||
|
||
async triggerExpandedPerformanceMetrics() { | ||
const expandedPerformanceMetrics = await getExpandedPerformanceMetrics(); | ||
this.messaging.notify('expandedPerformanceMetricsResult', expandedPerformanceMetrics); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.