-
Couldn't load subscription status.
- Fork 30
Remove blank page collection cache #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Tue, 28 Oct 2025 01:00:04 GMT AppleFile has changed IntegrationFile has changed WindowsFile has changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the page context caching logic to prevent caching of blank or empty page content. The changes ensure that mutation observers only start when there is actual content to observe and that empty content is not stored in the cache.
Key changes:
- Added document.body check before starting mutation observer
- Conditionally cache content only when it contains actual data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally within macOS by browsing to a page on Wikipedia and then browsing to https://www.thewholesomedish.com/the-best-homemade-tacos/. Without this change, page context is not attached automatically. With this change, it is.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211745324203561?focus=true
Description
Ignores both:
Testing Steps
Checklist
Please tick all that apply:
Note
Prevents caching blank page content and guards MutationObserver to start only when
document.bodyis available.injected/src/features/page-context.js):MutationObserveronly ifdocument.bodyexists.content.content.length > 0(skip empty content).Written by Cursor Bugbot for commit ff4983e. This will update automatically on new commits. Configure here.