Skip to content

Remove blank page collection cache #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

Remove blank page collection cache #2033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11bf627
Remove blank page collection cache
jonathanKingston Oct 24, 2025
ff4983e
Lint fix (why lol?)
jonathanKingston Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions injected/src/features/page-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ export default class PageContext extends ContentFeature {

startObserving() {
this.log.info('Starting observing', this.mutationObserver, this.#cachedContent);
if (this.mutationObserver && this.#cachedContent && !this.isObserving) {
if (this.mutationObserver && this.#cachedContent && !this.isObserving && document.body) {
this.isObserving = true;
this.mutationObserver.observe(document.body, {
childList: true,
Expand Down Expand Up @@ -445,7 +445,9 @@ export default class PageContext extends ContentFeature {
}

// Cache the result - setter handles timestamp and observer
this.cachedContent = content;
if (content.content.length > 0) {
this.cachedContent = content;
}
return content;
}

Expand Down
Loading