Skip to content

Add configurable timeout for perf metrics #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add configurable timeout for perf metrics #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af8fdc9
Add timeout parameter to performance metrics function
jonathanKingston Nov 21, 2025
6d37153
Pass permissableDelayMs to getExpandedPerformanceMetrics
jonathanKingston Nov 21, 2025
6530be6
Merge branch 'main' into jkt/timeoutPerfMetrics
jonathanKingston Nov 22, 2025
2c2ac98
Merge branch 'main' into jkt/timeoutPerfMetrics
jonathanKingston Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions injected/src/features/breakage-reporting/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function waitForLCP(timeoutMs = 500) {
* Get the expanded performance metrics
* @returns {Promise<ErrorObject | PerformanceMetricsResponse>}
*/
export async function getExpandedPerformanceMetrics() {
export async function getExpandedPerformanceMetrics(timeoutMs = 500) {
try {
if (document.readyState !== 'complete') {
return returnError('Document not ready');
Expand All @@ -80,7 +80,7 @@ export async function getExpandedPerformanceMetrics() {
// Get largest contentful paint if available
let largestContentfulPaint = null;
if (PerformanceObserver.supportedEntryTypes.includes('largest-contentful-paint')) {
largestContentfulPaint = await waitForLCP();
largestContentfulPaint = await waitForLCP(timeoutMs);
}

// Calculate total resource sizes
Expand Down
3 changes: 2 additions & 1 deletion injected/src/features/performance-metrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ export default class PerformanceMetrics extends ContentFeature {
}

async triggerExpandedPerformanceMetrics() {
const expandedPerformanceMetrics = await getExpandedPerformanceMetrics();
const permissableDelayMs = this.getFeatureSetting('expandedTimeoutMs') ?? 5000;
const expandedPerformanceMetrics = await getExpandedPerformanceMetrics(permissableDelayMs);
this.messaging.notify('expandedPerformanceMetricsResult', expandedPerformanceMetrics);
}
}