Add back private knn_search API for rest-api-spec generation #5737
+555
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2a24e33 since _knn_search is still needed in rest-api-spec to run YAML tests against it, as the API is still available with v8 compatibility mode. However, we make the API private so that it does not get back into clients, as it would fail with v9 compatibility.
Contributor
|
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
l-trotta
approved these changes
Nov 25, 2025
pquentin
changed the title
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5737-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 709ff2494b0fe79f86afc9301529624084ab6297
# Push it to GitHub
git push --set-upstream origin backport-5737-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
* Revert "Remove knn_search API (#4276)" This reverts commit 2a24e33 since _knn_search is still needed in rest-api-spec to run YAML tests against it, as the API is still available with v8 compatibility mode. However, we make the API private so that it does not get back into clients, as it would fail with v9 compatibility. * Add UpdateForV10 annotation * Fix lint (cherry picked from commit 709ff24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit #4276 since _knn_search is still needed in rest-api-spec to run YAML tests against it, as the API is
still available with v8 compatibility mode. However, we make the API private so it does not get back into clients, as it would fail due to v9 compatibility.
Additionally, we fix the compiler to ignore
UpdateForV10in all JSDoc blocks, given this is only meaningful at the ESLint level.