Skip to content

[ES|QL] fixing bug when handling 1d literal vectors #136891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

[ES|QL] fixing bug when handling 1d literal vectors #136891

merged 2 commits into from
Oct 22, 2025
+34 −1

Conversation

pmpailis
Copy link
Contributor

Simple fix to account for constant 1-d vectors after the refactoring in #135602. E.g.:

ROW left_vector = to_dense_vector([1.5])
| EVAL similarity = v_cosine(left_vector, 2.3)
| KEEP left_vector, similarity

Closes #136364

@pmpailis pmpailis added >bug :Search Relevance/ES|QL Search functionality in ES|QL labels Oct 21, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.3.0 labels Oct 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Hi @pmpailis, I've created a changelog YAML for you.

@pmpailis pmpailis merged commit f7a9cb5 into elastic:main Oct 22, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioanatia ioanatia ioanatia approved these changes

Assignees

No one assigned

Labels

>bug :Search Relevance/ES|QL Search functionality in ES|QL Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESQL: Vector similarity ClassCastException on 1-dimension literal vector

3 participants

@pmpailis @elasticsearchmachine @ioanatia