Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/136891.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 136891
summary: Fixing bug when handling 1d literal vectors
area: ES|QL
type: bug
issues:
- 136364
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,27 @@ public void testSimilarityBetweenConstantVectorAndField() {
}
}

@SuppressWarnings("unchecked")
public void testSimilarityWithOneDimVector() {
final float oneDimFloat = randomFloat();
final float[] randomVector = randomVectorArray(1);
var query = String.format(Locale.ROOT, """
ROW left_vector = to_dense_vector(%s)
| EVAL similarity = %s(left_vector, %f)
| KEEP left_vector, similarity
""", Arrays.toString(randomVector), functionName, oneDimFloat);
try (var resp = run(query)) {
List<List<Object>> valuesList = EsqlTestUtils.getValuesList(resp);
valuesList.forEach(values -> {
float[] left = new float[] { (float) values.get(0) };
Double similarity = (Double) values.get(1);
assertNotNull(similarity);
float expectedSimilarity = similarityFunction.calculateSimilarity(left, new float[] { oneDimFloat });
assertEquals(expectedSimilarity, similarity, 0.0001);
});
}
}

public void testDifferentDimensions() {
var randomVector = randomVectorArray(randomValueOtherThan(numDims, () -> randomIntBetween(32, 64) * 2));
var query = String.format(Locale.ROOT, """
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,13 @@ private static VectorValueProviderFactory getVectorValueProviderFactory(
EvaluatorMapper.ToEvaluator toEvaluator
) {
if (expression instanceof Literal) {
return new ConstantVectorProvider.Factory((ArrayList<Float>) ((Literal) expression).value());
ArrayList<Float> constantVector;
if (((Literal) expression).value() instanceof Float) {
constantVector = new ArrayList<>(List.of((Float) ((Literal) expression).value()));
} else {
constantVector = (ArrayList<Float>) ((Literal) expression).value();
}
return new ConstantVectorProvider.Factory(constantVector);
} else {
return new ExpressionVectorProvider.Factory(toEvaluator.apply(expression));
}
Expand Down