Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Nov 14, 2025

Content

Render Owner in the horizontal list when editing Admins.

Motivation and context

Follow design. Parity with iOS.
Closes #5634.

Screenshots / GIFs

Recorded ones should not change because the state of the preview was not matching what was previously computed.
So I have updated the preview state but it should have no effect.

Tests

  • Benoit creates a room.
  • Benoit upgrades room to v12.
  • Benoit goes to the Roles and permissions > Edit Owners or Admins

Benoit (Owner) is now displayed in the horizontal list of users.

image

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 14, 2025 16:43
@bmarty bmarty requested review from jmartinesp and removed request for a team November 14, 2025 16:43
@bmarty bmarty added the PR-Bugfix For bug fix label Nov 14, 2025
@bmarty bmarty requested a review from mxandreas November 14, 2025 16:45
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pJXJd7

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avatar not shown at all if permission can not be changed

2 participants