refactor: replace findOffsets helper with native methods
#536
+19
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-replace-findoffsets-helper-with-native-methods
This was referenced Sep 29, 2025
…or-replace-findoffsets-helper-with-native-methods
This was referenced Oct 1, 2025
…or-replace-findoffsets-helper-with-native-methods
…or-replace-findoffsets-helper-with-native-methods
1 task
1 task
…' of https://github.com/eslint/markdown into refactor-replace-findoffsets-helper-with-native-methods
…or-replace-findoffsets-helper-with-native-methods
mdjermanovic
deleted the
refactor-replace-findoffsets-helper-with-native-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've replaced the
findOffsetshelper function with the nativegetLocFromIndexmethod.I've removed all
findOffsets-related logic throughout the codebase.I also refactored
MarkdownSourceCodeto usegetLocFromIndexinternally.What changes did you make? (Give an overview)
In this PR, I've replaced the
findOffsetshelper function with the nativegetLocFromIndexmethod.Related Issues
Refs: https://github.com/eslint/css/pull/376, eslint/rewrite#212
Is there anything you'd like reviewers to focus on?
N/A