Skip to content

Update primitive.yaml: Add Bytes primitive #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update primitive.yaml: Add Bytes primitive #484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e7098f
Update primitive.yaml: Add Bytes primitive
ryanschneider Dec 6, 2024
c428672
fixup: update Bytes regex to hex pairs.
ryanschneider Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions types/primitive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ Bitvector:
example: "0x01"
pattern: "^0x[a-fA-F0-9]{2,}$"

Bytes:
type: string
format: hex
description: "An arbitrary-length sequence of bytes"
Copy link
Member

@nflaig nflaig Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arbitrary-length / unbounded values are not SSZ compatible, you always have to define a maximum bound

Copy link
Author

@ryanschneider ryanschneider Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and close since ethereum/builder-specs#107 was closed as well. I guess better wording if we ever want to revisit this would be "An sequence of bytes with unspecified maximum length"

Copy link
Member

@nflaig nflaig Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"An sequence of bytes with unspecified maximum length"

You have to specify a maximum length, there is no unbounded type in ssz. That being said, it would still be possible for the execution requests list use case as you can just update the max length each hard fork if new request types are added

example: "0x02a94f5374fce5edbc8e2a8697c15331677e6ebf0b85103a5617937691dfeeb89b86a80d5dc9e3c9d3a1a0e7ce311e26e0bb732eabaa47ffa288f0d54de28209a62a7d29d098daeed734da114470da559bd4b4c7259e1f7952555241dcbc90cf194a2ef676fc6005f3672fada2a3645edb297a7553"
pattern: "^0x([0-9a-fA-F][0-9a-fA-F])+$"

Uint8:
type: string
description: "Unsigned 8 bit integer, max value 255"
Expand Down